Improved element xsi:type includeTargetNamespace logic #20
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Improves on #19:
Deciding based on
qualified
to import the namespace can lead to issues:The qualified property decides wether the element is prefixed or not and should therefor not solely be used to decide wether to import the xsi:type namespace. In this PR, an additional check of the
targetNamespace !== namespace
is added.This makes configuring the encoder simpler as well: