Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial implementation #1

Merged
merged 5 commits into from
Jun 3, 2020
Merged

Initial implementation #1

merged 5 commits into from
Jun 3, 2020

Conversation

pfrenssen
Copy link
Member

No description provided.

Copy link
Contributor

@claudiu-cristea claudiu-cristea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent job. I have only two remarks regarding this repo:

  1. I see this entry in composer.json:
    "autoload": {
        "psr-4": {
            "TaskRunner\\Scss\\": "./src/"
        }
    },
    and I cannot figure out which file/class needs this mapping.
  2. I think this repo deserves a README.md, even it's a very brief one. We probably can show there the build badge (?)

@pfrenssen
Copy link
Member Author

Excellent job. I have only two remarks regarding this repo:

1. I see this entry in `composer.json`:
   ```json
   "autoload": {
       "psr-4": {
           "TaskRunner\\Scss\\": "./src/"
       }
   },
   ```
   
   
   and I cannot figure out which file/class needs this mapping.

It's for this file: https://github.com/php-task-runner/scss/pull/1/files#diff-751a1a04aa678c64079d89761e859347

@claudiu-cristea claudiu-cristea merged commit 7c9b72f into master Jun 3, 2020
@claudiu-cristea claudiu-cristea deleted the initial-implementation branch June 3, 2020 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants