Used uuid as doctrine-identifier #24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
wachterjohannes
force-pushed
the
enhancement/uuid-identifier
branch
from
0b41389 to
50c7799
Compare
danrot
requested changes
Nov 23, 2016
|
|
||
| #### Identifier of tasks and executions | ||
|
|
||
| The `id` field has be removed in favour of the `uuid`. This field is of |
| * Disable foreign keys checking by running this query: | ||
| `set foreign_key_checks=0;` | ||
| * Run the queries from `doctrine:schema:update` | ||
| * Enable back foreign key checking with : `set foreign_key_checks=1;` |
There was a problem hiding this comment.
Is this really enough? Does mysql regenerate new UUIDs?
There was a problem hiding this comment.
the uuids are there. the id was additionally generated before.
| #### Identifier of tasks and executions | ||
|
|
||
| The `id` field has be removed in favour of the `uuid`. This field is of | ||
| type `guid` and can be used before flush. |
| @@ -44,4 +44,14 @@ public function create($className) | |||
|
|
|||
| return $this->handler[$className]; | |||
| } | |||
|
|
|||
| /** | |||
| * Returns all known handler. | |||
There was a problem hiding this comment.
I think it should be handlers in general, shouldn't it? Don't know if it is worth the BC break to rename.
There was a problem hiding this comment.
until now it shouldn`t be a bc-break this method is new.
wachterjohannes
force-pushed
the
enhancement/uuid-identifier
branch
from
50c7799 to
a0549bc
Compare
|
@danrot thanks for review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the additional id property of task and execution. The uuid can be used earlier because it will be generated during construct.