Issue #6: Let user add global options. #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drupol
force-pushed
the
6-globals-options
branch
2 times, most recently
from
70f1188 to
89e6e98
Compare
3 tasks
drupol
changed the title
drupol
force-pushed
the
6-globals-options
branch
from
0d2d1ec to
1875904
Compare
jfhovinne
approved these changes
Jul 31, 2019
drupol
added a commit
that referenced
this pull request
Aug 13, 2019
* Feature: Let user add global options. * Feature: Refactoring. * Feature: Remove obsolete test now that we refactored the working_dir option. * Feature: Take in account the mode and get rid of latest PHPCS errors. * Fix PHPStan issue because of upgrade of consolidation/robo. * Improve functional tests. * Add missing parenthesys to avoid wrong order of operations. * Prevent issue when no working-dir is set on command line. * Move the method to another place, to be aligned with other method. * Use "options." instead of "taskman.". * Update documentation. * Let user customize options shortcuts. * Fix CS. * Typos
ghost
reviewed
Aug 16, 2019
|
|
||
| taskman: |
There was a problem hiding this comment.
This breaks compatibility with phptaskman/drupal that depends on taskman.bin_dir: https://github.com/php-taskman/drupal/blob/master/src/Robo/Plugin/Commands/AbstractDrupalCommands.php#L316
Should we release a new version of phptaskman/drupal with a dependency to 1.0.5 or rethink the renaming of this property?
There was a problem hiding this comment.
We should update it :(
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Fixes #6