Skip to content

Conversation

thinkingmedia
Copy link
Contributor

Movie "releases" is now deprecated. The API will still return results for it, but the data is no longer being updated. So it can contain incorrect data.

People should be using "release_dates" instead as it contains release type, and is also being updated now.

This PR adds the release_dates append_to_response constant.

@drone-ah
Copy link

drone-ah commented Feb 15, 2017

Hi,

I have added a commit in the following branch to add getters/setters for release_dates within the movie model
https://github.com/drone-ah/api/tree/release_dates

HTH,

@thinkingmedia
Copy link
Contributor Author

@drone-ah thanks for the improvement.

I don't think that change is consistent with how the library handles properties of a movie. I'll take a look and see if I can fix it.

Thanks,

@thinkingmedia
Copy link
Contributor Author

I've added a new ReleaseDate and update Movies. I still need to add tests for these new changes.

@drone-ah
Copy link

@thinkingmedia Thank you :)

@drone-ah
Copy link

@thinkingmedia I have picked up your latest code. In this, you have deprecated getReleaseDates() suggesting to use getReleaseDates instead. I assume this is a mistake and this method shouldn't be deprecated. If this is correct, perhaps the comment could be clearer?

Thanks

@thinkingmedia
Copy link
Contributor Author

@drone-ah I haven't actually tried these changes yet. Is it working for you?

I'm unable to run phpunit for some reason. So I opened this issue #141 and maybe I can get some help with that. Once that is working I can update the tests and this can get merged.

@wtfzdotnet
Copy link
Member

@thinkingmedia rebase on the 2.1 branch and push your commits again :), I have restricted the phpunit version to <6

@thinkingmedia
Copy link
Contributor Author

@wtfzdotnet Awesome, the tests are working now. thank you!

I'll add some more tests now.

@wtfzdotnet
Copy link
Member

Could you give it another rebase? Just modified the travis.yml to make sure it is tested against symfony 3.2.* components. Give me a heads up when you feel like it's done for review.

@thinkingmedia
Copy link
Contributor Author

@wtfzdotnet okay, I'm finished. Travis should pass but we can wait to be sure.

@thinkingmedia
Copy link
Contributor Author

@wtfzdotnet ping

@wtfzdotnet wtfzdotnet merged commit 5aae080 into php-tmdb:2.1 Feb 28, 2017
@wtfzdotnet
Copy link
Member

@thinkingmedia I'm really assuming all is good here, time is really really sparse for me lately and I'm going to be busy until next week again. Just pushing a quick release out now!

@thinkingmedia
Copy link
Contributor Author

@wtfzdotnet everything is good!

If you are that busy. How about inviting me to me a member? I can help with closing issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants