-
-
Notifications
You must be signed in to change notification settings - Fork 115
added RELEASE_DATES #139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added RELEASE_DATES #139
Conversation
Hi, I have added a commit in the following branch to add getters/setters for release_dates within the movie model HTH, |
@drone-ah thanks for the improvement. I don't think that change is consistent with how the library handles properties of a movie. I'll take a look and see if I can fix it. Thanks, |
I've added a new ReleaseDate and update Movies. I still need to add tests for these new changes. |
@thinkingmedia Thank you :) |
@thinkingmedia I have picked up your latest code. In this, you have deprecated getReleaseDates() suggesting to use getReleaseDates instead. I assume this is a mistake and this method shouldn't be deprecated. If this is correct, perhaps the comment could be clearer? Thanks |
@thinkingmedia rebase on the 2.1 branch and push your commits again :), I have restricted the phpunit version to <6 |
@wtfzdotnet Awesome, the tests are working now. thank you! I'll add some more tests now. |
Could you give it another rebase? Just modified the travis.yml to make sure it is tested against symfony 3.2.* components. Give me a heads up when you feel like it's done for review. |
…kingmedia/api into thinkingmedia/release_dates
@wtfzdotnet okay, I'm finished. Travis should pass but we can wait to be sure. |
@wtfzdotnet ping |
@thinkingmedia I'm really assuming all is good here, time is really really sparse for me lately and I'm going to be busy until next week again. Just pushing a quick release out now! |
@wtfzdotnet everything is good! If you are that busy. How about inviting me to me a member? I can help with closing issues. |
Movie "releases" is now deprecated. The API will still return results for it, but the data is no longer being updated. So it can contain incorrect data.
People should be using "release_dates" instead as it contains release type, and is also being updated now.
This PR adds the release_dates append_to_response constant.