Skip to content

Pass relative path to HTTP adapters, 2.0 branch #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 9, 2017
Merged

Pass relative path to HTTP adapters, 2.0 branch #157

merged 2 commits into from
Sep 9, 2017

Conversation

yukoff
Copy link
Contributor

@yukoff yukoff commented Sep 9, 2017

This is a follow-up #149 for 2.0 branch, quote from the initial PR:

This patch restores the way paths are stored in Tmdb\HttpClient\Request. The base URL is no longer part of the path and is passed to the HTTP adapter as part of the options bag (fixes #145).

Note: Custom HTTP adapters which do not follow the documented practice will probably break after applying this change.

@yukoff yukoff self-assigned this Sep 9, 2017
@yukoff yukoff added this to the v2.0.19 milestone Sep 9, 2017
@yukoff yukoff merged commit 17659c1 into php-tmdb:2.0 Sep 9, 2017
@yukoff yukoff deleted the 2.0-fix-insecure-requests branch September 9, 2017 05:13
yukoff added a commit that referenced this pull request Sep 9, 2017
@yukoff
Adjust for guzzle 5.x (#157)
3c4498b 
This partially reverts afa2702 in parts
that are only related to guzzle 6.x
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@yukoff yukoff

Labels
None yet
Projects
None yet
Milestone
v2.0.19
Development

Successfully merging this pull request may close these issues.
2 participants
@yukoff @z38