Skip to content

Conversation

greg0ire
Copy link
Contributor

There does not seem to be any BC break that affects php-tmdb. The only
documented BC break is here:
Kevinrob/guzzle-cache-middleware#75

There does not seem to be any BC break that affects php-tmdb. The only
documented BC break is here:
Kevinrob/guzzle-cache-middleware#75
@wtfzdotnet
Copy link
Member

Want to take a little time to look into this when I have the time for it, just to see what has changed between the versions so I can estimate the impact of the change. Thanks for the contribution and helpful link to some docs ;) I'll try to get back to you by Fri at the latest.

@greg0ire
Copy link
Contributor Author

Great! Looks like it's mostly tests: Kevinrob/guzzle-cache-middleware@v1.5.2...master

@wtfzdotnet
Copy link
Member

The problem is I'd assume this is fine to merge and just hit the button and say thanks, but I just want to run some tests so see the implications of this, which again I expect to be none, but I'd rather make sure :).

@greg0ire
Copy link
Contributor Author

Sure thing! Better be safe than sorry... I just wanted to help you seeing the diff.

@wtfzdotnet
Copy link
Member

Been preoccupied I am sorry mate! Taking a look tomorrow

@greg0ire
Copy link
Contributor Author

greg0ire commented Nov 4, 2017

Relax, there is really no hurry at all, I only did that to keep my composer outdated output empty ;)

@greg0ire
Copy link
Contributor Author

ping ;)

@wtfzdotnet
Copy link
Member

I know right... been ill in between and busy again, and at work right now, next weekend busy again so I will really try to get to this before then 🥇

@wtfzdotnet wtfzdotnet merged commit d6d53b2 into php-tmdb:2.1 Nov 19, 2017
@wtfzdotnet
Copy link
Member

Thanks for the contribution ;) sorry it took a while!

@greg0ire greg0ire deleted the guzzle_cache_middleware_2 branch November 19, 2017 10:27
@greg0ire
Copy link
Contributor Author

Thanks for merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants