Skip to content

Conversation

z38
Copy link
Contributor

@z38 z38 commented May 14, 2017

With symfony/symfony#22185 (^3.3), named keys in service configuration files are no longer silently ignored. Now, the following exception is thrown:

[Symfony\Component\DependencyInjection\Exception\InvalidArgumentException]        
Invalid key "event_dispatcher" found in arguments of method "__construct()" for
service "tmdb.configuration": only integer or $named arguments are allowed.

As they keys were ignored anyway, it's safe to remove them.

@yukoff
Copy link
Contributor

yukoff commented May 31, 2017

+1 @wtfzdotnet This also should go to 2.1 and I guess it's time to merge 2.0 and 2.1 into master? ;)

@yukoff yukoff self-assigned this Jun 1, 2017
@yukoff yukoff added the bug label Jun 1, 2017
@yukoff yukoff merged commit 7a4229d into php-tmdb:2.0 Jun 1, 2017
@yukoff
Copy link
Contributor

yukoff commented Jun 1, 2017

This one related to symfony/symfony#22979.

A quote form this comment:

Iirc, using the key like this was meaningless before 3.3 - it just added this as the first argument. We made this explicitly illegal in 3.3 - so you should just remove this. But, it is a minor BC break.

@z38 z38 deleted the fix-service-configuration branch June 3, 2017 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants