-
Notifications
You must be signed in to change notification settings - Fork 25
Added configuration options #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi Nicolas, First of all thanks for your kind words an contribution, it's appreciated! :-) I just want to emphasize I love the fact you also took care of the README markdown document. I've reviewed your pull request quickly in public transport earlier :-), I'll be taking a quick look at it in a second from my desktop as I just got home. Honestly I had my doubts about making the caching and logging enabled by default, and I'm still not sure if logging should be, however I can agree enabling caching by default would be a good idea, as it would be just following general http protocol. Would you mind emphasizing why logging should be enabled by default? Thanks, Michael |
@@ -14,21 +14,55 @@ wtfz_tmdb: | |||
|
|||
That's all! Fire away! | |||
|
|||
__Want to make use of default caching?__ | |||
__Default caching and loggin capabilities?__ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo loggin
=> logging
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, typo !
Thank you again for the contribution, if you could take care of the notes I've made I'll be happy to merge it in. Would you mind if I'd contact you directly about something? :-). Thanks, Michael |
There also is still a reference at the bottom in |
Hi, Thanks for your reply. About enabling logging by default, I tend to log every possible thing in my applications. And even more when it comes to external calls like APIs. But you're right, I'll reset the default behavior for cachind and logging as it is not everyone preference. I'll take care of your notes and update the PR as soon as I can. And of course you can contact me :) Nicolas |
Hi, I just fixed the README and set back caching and logging default behavior :) |
Thanks again, I'll contact you later about something :-) |
Hi,
First of all, let me thank you for your bundle and library, you have saved me a lot of time lately :)
As an intensive Symfony2 user, I'd like to propose this small PR to enhance the bundle by adding :
symfony/symfony
to composer dependenciesI updated the README, and there should be no BC break, although caching and logging are now enabled by default (but since doctrine cache and monolog are required in composer I don't think it's a problem).
Thanks !