Fixed wrong operand precedence #258
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you. |
|
Well, I made this fix because I had errors: instead of extract the right
value provided by the desc filter, it extracted "true", that was converted
to "1" the translation file. Now it works correctly.
…On Wed, Sep 5, 2018 at 10:45 AM Tobias Nyholm ***@***.***> wrote:
Thank you.
I know these assignments are not perfect for open source because they
might be hard to read. Your parentheses may help. However, they have no
effect for the execution. The result will be exactly the same.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#258 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/APaj78wgUU_PMyvcRuooggmJ2JwMxmP6ks5uX48-gaJpZM4WaZ7s>
.
|
|
Oh, I might be wrong. Anyhow. If you are sure that this will fix your issue then I'm happy to merge. Thank you! |
Nyholm
approved these changes
Sep 5, 2018
|
You are welcome!
…On Wed, Sep 5, 2018 at 10:54 AM Tobias Nyholm ***@***.***> wrote:
Oh, I might be wrong.
It was && ...
Anyhow. If you are sure that this will fix your issue then I'm happy to
merge. Thank you!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#258 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/APaj7wNZEqE5sdtLZYt0HXoVm7lRUH-Tks5uX5EvgaJpZM4WaZ7s>
.
|
|
Hey @Nyholm, would be great if you could release a new version / tag containing this fix. It has been biting us for quite some time. Thanks in advance ;]! |
|
Sure! |
|
Finally tagged :)
//Tobias Nyholm
Skickat på språng
… On 2 Oct 2018, at 08:21, Harm van Tilborg ***@***.***> wrote:
Hey @Nyholm, would be great if you could release a new version / tag containing this fix. It has been biting us for quite some time. Thanks in advance ;]!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.