register visitor tag also for TranslateAnnotationVisitor and Knp visitors #451
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @Guite ! Sorry for the long deeply, the tests were fixed in master, could you pull the new changes to see we're still green here? |
|
merged the latest master into my fork |
bocharsky-bw
approved these changes
Jan 20, 2022
There was a problem hiding this comment.
Thank you for this improvement and the fast update on it!
Looks good to me, it matches the file structure: https://github.com/php-translation/extractor/tree/296026263aeabb5f17c6b6958608ba255b92ad9c/src/Visitor/Php
bocharsky-bw
added a commit
that referenced
this pull request
Jan 20, 2022
bocharsky-bw
added a commit
that referenced
this pull request
Jan 20, 2022
* Prepare release v0.12.4 * Update Changelog.md * Include merged #451 PR in the changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #402