Skip to content

use class constants instead of string literals #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 10 commits into from
Closed

use class constants instead of string literals #28

wants to merge 10 commits into from

Conversation

djoudi
Copy link
Contributor

@djoudi djoudi commented Apr 17, 2018

No description provided.

xabbuh
xabbuh requested changes Apr 17, 2018
View reviewed changes
Copy link
Contributor

@xabbuh xabbuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please update to not change the line ending character? :)

@xabbuh
Copy link
Contributor

xabbuh commented Apr 25, 2018

see #33, thank you @djoudi for doing the initial work

@xabbuh xabbuh closed this Apr 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xabbuh xabbuh xabbuh requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@djoudi @xabbuh @EcoinTest