Add a StateDocumentsFilter class #47
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Re reading this part of the specification, I'm uncertain on what model we should handle. Is it just State or the StateDocument ? WDYT @xabbuh ? |
|
I'm almost certain it's StateDocument. It doesn't have any sense otherwise. |
|
Thank you @Lctrs. |
xabbuh
added a commit
that referenced
this pull request
Jun 5, 2017
This PR was submitted for the master branch but it was merged into the 1.x branch instead (closes #47). Discussion ---------- Add a StateDocumentsFilter class Prepare the implementation of https://github.com/adlnet/xAPI-Spec/blob/master/xAPI-Communication.md#23-state-resource Basically, what I have in mind is to mimic the implementation for Statements by adding : - a filter class in this package (this PR) - a repository interface in the `php-xapi/repository-api` package - a serializer interface in the `php-xapi/serializer` package Then do the works in our LrsBundle. Commits ------- 889a9aa Add a StateDocumentsFilter class
xabbuh
added a commit
that referenced
this pull request
Jun 5, 2017
xabbuh
added a commit
that referenced
this pull request
Apr 23, 2018
* 1.x: bump version for removal of deprecated features drop build job for HHVM [#47] add changelog entry Add a StateDocumentsFilter class Deprecate constructing State with anything other than Agent as 2nd argument [#60] remove unneeded docblocks Introduce a new Person class add spec test to not use version when comparing
xabbuh
added a commit
that referenced
this pull request
Apr 23, 2018
* 2.x: update year in license fix typo bump version for removal of deprecated features fix Travis CI job update changelog bump version for removal of deprecated features drop build job for HHVM [#47] add changelog entry Add a StateDocumentsFilter class Deprecate constructing State with anything other than Agent as 2nd argument [#60] remove unneeded docblocks Introduce a new Person class add spec test to not use version when comparing Conflicts: .travis.yml CHANGELOG.md src/State.php
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prepare the implementation of https://github.com/adlnet/xAPI-Spec/blob/master/xAPI-Communication.md#23-state-resource
Basically, what I have in mind is to mimic the implementation for Statements by adding :
php-xapi/repository-apipackagephp-xapi/serializerpackageThen do the works in our LrsBundle.