Deprecate constructing State with anything other than Agent as 2nd argument #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you also add an entry to the changelog? |
|
After thinking about this again I think we should do the following:
We can then merge this into the |
Lctrs
changed the title
|
@xabbuh Done. Any feedback on this ? |
|
@Lctrs Oh, yes indeed please. |
|
Thank you @Lctrs. |
xabbuh
added a commit
that referenced
this pull request
Jun 5, 2017
…nt as 2nd argument (Lctrs) This PR was squashed before being merged into the 1.x branch (closes #52). Discussion ---------- Deprecate constructing State with anything other than Agent as 2nd argument Close #49. Commits ------- ea360c6 Deprecate constructing State with anything other than Agent as 2nd argument
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #49.