-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix translation of literal code #140
Conversation
@joshuaruesweg I'm sorry about that and I knew this would probably happen sooner or later. That's why as for that file it's perfectly fine for me to replace it with your version. What I intended to suggest (should have also done so) is that when somebody starts a new translation, the first thing to do is to push the file with the EN-Revision line and "status wip" or alternatively send an email. |
I hadn't finished the translation yet, so it fits for me to have your translation in it. No worries :) I will then in the future simply open a draft PR before, which starts with the English version of the file, before I start to translate. Then the whole thing is completely obvious for everyone and probably easier than sending any emails. |
OK, good idea, so will I. Do you know how to do it on the commandline? |
You mean opening Pull-Request with the commandline [1]? Or what exactly do you mean? [1] I know, there is a command like |
Thanks. I'll do some RTFM. ;) |
language/attributes.xml
Outdated
@@ -323,7 +323,7 @@ class MyAttribute | |||
<para> | |||
Um den Typ der Deklaration einzuschränken, dem ein Attribut zugeordnet | |||
werden kann, kann eine Bitmaske als erstes Argument an die | |||
<literal>#[Attribut]</literal>-Deklaration übergeben werden. | |||
<literal>#[Attribute]</literal>-Deklaration übergeben werden. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed with review.
language/attributes.xml
Outdated
@@ -367,7 +367,7 @@ class MyAttribute | |||
<para> | |||
Standardmäßig kann ein Attribut nur einmal pro Deklaration verwendet | |||
werden. Wenn das Attribut bei Deklarationen wiederholbar sein soll, muss | |||
dies als Teil der Bitmaske der <literal>#[Attribut]</literal>-Deklaration | |||
dies als Teil der Bitmaske der <literal>#[Attribute]</literal>-Deklaration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed with review.
This file was tagged as "wip" for a review. With this review I already fixed some of the above. |
Thanks, yes, I had overlooked the WIP within the comment. That still takes a lot of getting used to for me, because intuitively I would work with own branches for things that aren't ready yet (and draft pull requests accordingly, if needed). If the documentation is ready, it will be merged with an Pull-Request into But yes, I'll keep in mind how you guys do it here and adapt accordingly. Thanks for the clarification! |
I don't know, how others do this and probably there are better ways (e.g. the afore mentioned draft PRs). I just installed gh, the official github commandline tool. Up until now I've used git commands. |
Should I fix this or do uptate your PR with the latest base branch so this can be committed directly? |
a0b11eb
to
4c3549a
Compare
Fix personalisation.
I have rebased the commit accordingly. If you want, you can merge it together with yours! :) |
Again thanks a lot. |
See a6a3ac0
@msamesch Is there a way to communicate with you about what things you're translating next? Was the problem currently simply not there, because you translated practically alone?
We unfortunately overlapped and I had also (started) translating the attributes. This is vexing and (hopefully) avoidable.