Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypt: Fix example #161

Merged
merged 4 commits into from
Oct 4, 2023
Merged

crypt: Fix example #161

merged 4 commits into from
Oct 4, 2023

Conversation

TimWolla
Copy link
Member

@TimWolla TimWolla commented Oct 2, 2023

The example is not properly in sync with the English version and got broken in 588eb36.

@TimWolla
crypt: Fix example
70a768d 
The example is not properly in sync with the English version and got broken in 588eb36.
@TimWolla
crypt: Fix wording in comment in example
56b636e
msamesch
msamesch reviewed Oct 3, 2023
View reviewed changes
Copy link
Contributor

@msamesch msamesch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the fix.

@TimWolla TimWolla requested a review from msamesch October 3, 2023 22:22
@msamesch
Copy link
Contributor

msamesch commented Oct 4, 2023

Thanks a lot. Now even I get it. ;-)

@msamesch msamesch merged commit c56e60f into php:master Oct 4, 2023
1 check passed
@TimWolla TimWolla deleted the crypt-example branch October 4, 2023 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Girgias Girgias Girgias left review comments

@msamesch msamesch Awaiting requested review from msamesch

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TimWolla @msamesch @Girgias