Skip to content

[PHP 8.1] Add sodium ristretto255 functions #1051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Apr 16, 2022
Merged

[PHP 8.1] Add sodium ristretto255 functions #1051

merged 9 commits into from
Apr 16, 2022

Conversation

saundefined
Copy link
Member

@saundefined saundefined commented Oct 26, 2021 •
edited
Loading

  • sodium_crypto_core_ristretto255_add
  • sodium_crypto_core_ristretto255_from_hash
  • sodium_crypto_core_ristretto255_is_valid_point
  • sodium_crypto_core_ristretto255_random
  • sodium_crypto_core_ristretto255_scalar_add
  • sodium_crypto_core_ristretto255_scalar_complement
  • sodium_crypto_core_ristretto255_scalar_invert
  • sodium_crypto_core_ristretto255_scalar_mul
  • sodium_crypto_core_ristretto255_scalar_negate
  • sodium_crypto_core_ristretto255_scalar_random
  • sodium_crypto_core_ristretto255_scalar_reduce
  • sodium_crypto_core_ristretto255_scalar_sub
  • sodium_crypto_core_ristretto255_sub
  • sodium_crypto_scalarmult_ristretto255
  • sodium_crypto_scalarmult_ristretto255_base

@saundefined saundefined added this to the PHP 8.1 milestone Oct 26, 2021
@saundefined saundefined mentioned this pull request Oct 26, 2021
Closed
@saundefined saundefined force-pushed the php81-sodium-ristretto255 branch from 6d421a3 to 249dd6e Compare October 26, 2021 12:35
@saundefined saundefined force-pushed the php81-sodium-ristretto255 branch from e0fedfb to 198c533 Compare October 27, 2021 05:01
@saundefined
Copy link
Member Author

@paragonie-security can you review this PR as the author of the implementation?

@saundefined
Copy link
Member Author

@cmb69 @Girgias can we merge this PR and #1045 as is, and improve descriptions if necessary in the future, what do you think?

Or I can replace it with &warn.undocumented.func; 🤔

@Girgias
Copy link
Member

Girgias commented Apr 8, 2022

@paragonie-security Do you have time to do a quick review of these functions?

If there is no reply in a week I think merging with &warn.undocumented.func; is OK

@saundefined saundefined changed the title [WIP][PHP 8.1] Add sodium ristretto255 functions [PHP 8.1] Add sodium ristretto255 functions Apr 14, 2022
@saundefined saundefined marked this pull request as ready for review April 14, 2022 07:00
@saundefined
Copy link
Member Author

Appended the &warn.undocumented.func; tag, if there are no objections, I plan to merge both PRs tomorrow.

If anything, we can always catch up in the future :)

@saundefined saundefined merged commit 133b912 into php:master Apr 16, 2022
@saundefined saundefined deleted the php81-sodium-ristretto255 branch April 16, 2022 10:56
tiffany-taylor pushed a commit to tiffany-taylor/doc-en that referenced this pull request Jan 16, 2023
@saundefined @tiffany-taylor
[PHP 8.1] Add sodium ristretto255 functions (php#1051)
17ec74b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
PHP 8.1
Development

Successfully merging this pull request may close these issues.
3 participants
@saundefined @Girgias @afilina