Skip to content

Conversation

localheinz
Copy link
Contributor

This PR

  • removes the non-existent $serverctrls parameter from the documentation for ldap_bind()

💁‍♂ When looking at (for example)

it's not apparent that ldap_bind() accepts 4 arguments. It does not have a $serverctrls parameter.

@OskarStark
Copy link

Maybe it was mixed up with ldap_bind_ext()

@nikic
Copy link
Member

nikic commented Jan 17, 2020

@php-pulls merge

@php-pulls php-pulls closed this in c475a1e Jan 17, 2020
salathe pushed a commit to salathe/phpdoc-en that referenced this pull request Jan 17, 2020
Patch by localheinz.

Closes php/doc-en#20.

git-svn-id: https://svn.php.net/repository/phpdoc/en/trunk@348935 c90b9560-bf6c-de11-be94-00142212c4b1
@localheinz
Copy link
Contributor Author

Hmm, awesome!

@localheinz localheinz deleted the fix/ldap-bind branch January 17, 2020 15:16
@localheinz
Copy link
Contributor Author

Thank you, @nikic, @OskarStark, and @salathe!

@OskarStark
Copy link

Awesome 😎🥳

LeSuisse added a commit to LeSuisse/psalm that referenced this pull request Feb 2, 2020
In a8e58b0 a `$serverctrls` parameter
was incorrectly added to the \ldap_bind() function.

See php/doc-en#20.
muglug pushed a commit to vimeo/psalm that referenced this pull request Feb 2, 2020
In a8e58b0 a `$serverctrls` parameter
was incorrectly added to the \ldap_bind() function.

See php/doc-en#20.
heiglandreas pushed a commit to phpdoctest/en that referenced this pull request Feb 4, 2020
Patch by localheinz.

Closes php/doc-en#20.

git-svn-id: https://svn.php.net/repository/phpdoc/en/trunk@348935 c90b9560-bf6c-de11-be94-00142212c4b1
salathe pushed a commit to salathe/phpdoc-en that referenced this pull request Sep 3, 2020
Patch by localheinz.

Closes php/doc-en#20.

git-svn-id: https://svn.php.net/repository/phpdoc/en/trunk@348935 c90b9560-bf6c-de11-be94-00142212c4b1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants