Standardise casting spacing #2717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Girgias
approved these changes
Aug 29, 2023
|
Thanks. Appreciate the reviews. |
|
Sorry for the delay, could you rebase this on the latest master? |
Co-authored-by: George Peter Banyard <girgias@php.net>
timacdonald
force-pushed
the
tutorial-cast
branch
from
4bc0b59
to
148e78c
Compare
|
@Girgias, no apologies needed! I've just rebased against master here and re-checked the repository in case others had been introduced. This should be good to go. |
|
Ah thanks for the ping, I forgot about this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR standardises the spacing of casting in PHP via
(bool) $valuestyle casts.We currently have an inconsistent usage. I feel that we should standardise on a single space, which is commonly used in the community and also helps separate the "cast" from the "value".