password_hash: Update script to generate cost recommendations #2784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
50 ms is way to short to generate actually secure hashes. Update the recommendation to 350 ms with a starting cost of 10 (the current default) and example output of 12. see https://wiki.php.net/rfc/bcrypt_cost_2023
TimWolla
force-pushed
the
password-hash-cost
branch
from
aa6bc0f
to
385a3de
Compare
TimWolla
added a commit
to TimWolla/php-doc-en
that referenced
this pull request
Sep 22, 2023
The old example was broken, because the `cost` option is only valid for bcrypt, but not for argon2. Thus in case the default algorithm actually changes, the example would be broken. Also update the example costs with 12 as per php#2784.
Girgias
approved these changes
Sep 22, 2023
Girgias
pushed a commit
that referenced
this pull request
Sep 22, 2023
The old example was broken, because the `cost` option is only valid for bcrypt, but not for argon2. Thus in case the default algorithm actually changes, the example would be broken. Also update the example costs with 12 as per #2784.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
50 ms is way to short to generate actually secure hashes. Update the recommendation to 350 ms with a starting cost of 10 (the current default) and example output of 12.
see https://wiki.php.net/rfc/bcrypt_cost_2023
/cc @roycewilliams