Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error_reporting: Fix return value description #2805

Merged
merged 1 commit into from
Oct 16, 2023

Conversation

imme-emosol
Copy link
Contributor

No description provided.

@TimWolla TimWolla changed the title Reword error_reporting return value description error_reporting: Fix return value description Oct 16, 2023
@TimWolla TimWolla merged commit 2fe8d67 into php:master Oct 16, 2023
2 checks passed
@TimWolla
Copy link
Member

Thank you!

@imme-emosol
Copy link
Contributor Author

I just realized that a strict interpretation of the wording might read to mean:

  • first return the value,
  • then change it.

Which is probably not how it works.

As such, a nitpick suggestion:

- Returns the error_reporting level, before it is changed to error_level.
+ Returns the error_reporting level, as before it was changed to error_level.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants