Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PHP 8.3] IntlCalendar setDate / setDateTime #2919

Merged
merged 1 commit into from
Nov 6, 2023
Merged

[PHP 8.3] IntlCalendar setDate / setDateTime #2919

merged 1 commit into from
Nov 6, 2023

Conversation

saundefined
Copy link
Member

@saundefined saundefined mentioned this pull request Nov 6, 2023
Open
@saundefined saundefined added this to the PHP 8.3 milestone Nov 6, 2023
Girgias
Girgias approved these changes Nov 6, 2023
View reviewed changes
Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks reasonable even if I don't know ICU really

@saundefined saundefined merged commit 2a9c4f5 into php:master Nov 6, 2023
2 checks passed
@saundefined saundefined deleted the intlcal-set branch November 6, 2023 13:05
@Girgias
Copy link
Member

Girgias commented Nov 6, 2023

Just remembered, you need to update the versions.xml file

@saundefined
Copy link
Member Author

Yeah, just remembered that too :)
Thanks, I'll do it now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Girgias Girgias Girgias approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
PHP 8.3
Development

Successfully merging this pull request may close these issues.
2 participants
@saundefined @Girgias