Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8.3 documentation tracker #2796

Open
Girgias opened this issue Sep 26, 2023 · 9 comments
Open

PHP 8.3 documentation tracker #2796

Girgias opened this issue Sep 26, 2023 · 9 comments
Labels
help wanted Extra attention is needed
Milestone

Comments

@Girgias
Copy link
Member

Girgias commented Sep 26, 2023

Pages which need to be added/modified for complete documentation of PHP 8.3:

Based of the migration guide: https://www.php.net/manual/en/migration83.php (#2780):

Note
This issue is still a Work In Progress

Core

SAPI

Extensions

Classes

New Constants

Other Changes

  • Core changes

    • FFI::load() is now allowed during preloading when opcache.preload_user is the current system user.
    • In the CLI and phpdbg SAPIs, preloading does not require the opcache.preload_user directive to be set anymore when running as root.
  • Changed Functions

  • Calendar

    • easter_date() now supports years from 1970 to 2,000,000,000 on 64-bit systems,
  • Curl

  • Gd

    • The signature of imagerotate() has changed.
  • mysqli

  • ODBC

  • Standard

    • password_hash() will now chain the underlying Random\RandomException as the ValueError's $previous Exception when salt generation fails.
    • If using an array as the $command for proc_open(), it must now have at least one non empty element. Otherwise a ValueError is thrown.which only contains an unterminated enclosure.
@Girgias Girgias added the help wanted Extra attention is needed label Sep 26, 2023
@Girgias Girgias added this to the PHP 8.3 milestone Sep 26, 2023
@Girgias
Copy link
Member Author

Girgias commented Sep 27, 2023

Note: I did not add the WeakMap, the Zend Max Execution Timers, and the call stack overflowing to the todo list from the BC Break page, as those are engine changes to just make it more sensible.

@saundefined saundefined pinned this issue Sep 28, 2023
@TimWolla
Copy link
Member

TimWolla commented Oct 1, 2023

New methods:

  • Random\Randomizer::getBytesFromString()
  • Random\Randomizer::nextFloat()
  • Random\Randomizer::getFloat()

These already have stubs and I've started writing the first bits and pieces of the actual contents.

@Girgias
Copy link
Member Author

Girgias commented Oct 5, 2023

Somehow looks like #2602 doesn't have any mention in the upgrading document?

@nielsdos
Copy link
Member

nielsdos commented Oct 5, 2023

Somehow looks like #2602 doesn't have any mention in the upgrading document?

Going by memory. This was a fix for https://bugs.php.net/bug.php?id=47137. I.e. the constant was documented on the libxml constant page, but it didn't work for the DOM save methods. At one point the docs were updated on those save pages to mention only one option worked. When I fixed it, I felt like it was on the border of a fix vs feature request. That combined with the fact it was a non trivial change made me decide to only put the fix in master.

@Girgias
Copy link
Member Author

Girgias commented Oct 5, 2023

Somehow looks like #2602 doesn't have any mention in the upgrading document?

Going by memory. This was a fix for https://bugs.php.net/bug.php?id=47137. I.e. the constant was documented on the libxml constant page, but it didn't work for the DOM save methods. At one point the docs were updated on those save pages to mention only one option worked. When I fixed it, I felt like it was on the border of a fix vs feature request. That combined with the fact it was a non trivial change made me decide to only put the fix in master.

ACK.

@TimWolla
Copy link
Member

Deprecated:
assertions:
The assert_options() function is now deprecated.
The ASSERT_ACTIVE, ASSERT_BAIL, ASSERT_CALLBACK, ASSERT_EXCEPTION, and ASSERT_WARNING constants have been deprecated.
The assert.* INI settings have been deprecated.

I believe all this has been resolved

@mumumu
Copy link
Member

mumumu commented Nov 2, 2023

Missing the Other Changes page

I've added it.

@haszi
Copy link
Contributor

haszi commented Jan 10, 2024

* [ ]  DOMNameSpaceNode::contains()

I've checked the PHP-8.3.2 branch and the PR that was supposed to add this method but couldn't find DOMNameSpaceNode::contains. Maybe this was added to NEWS accidentally?

@nielsdos
Copy link
Member

* [ ]  DOMNameSpaceNode::contains()

I've checked the PHP-8.3.2 branch and the PR that was supposed to add this method but couldn't find DOMNameSpaceNode::contains. Maybe this was added to NEWS accidentally?

Err yes, this method doesn't exist on that class, only on DOMNode. In fact it wouldn't make sense to add it on DOMNameSpaceNode...
So I added this to NEWS by mistake.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

5 participants