-
Notifications
You must be signed in to change notification settings - Fork 732
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add stubs/documentation for missing GMP functions #2924
Conversation
The issue is the GMP docs... |
f74e366
to
32d107f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok for constructor
I don't think there's a “drop-in” replacement functionality for them, though? |
0 and (2 ** <parameter>bits</parameter>) - 1. | ||
<literal>0</literal> and | ||
<code>(2 ** <parameter>bits</parameter>) - 1</code>. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As that changed: That could use <superscript>
. See:
The exact maximum can be calculated as 2<superscript>$engine_bytes * 8 - 1</superscript> - 1. |
Right, I just find the "bits" variant a bit strange but they do work with arbitrary large integer numbers. |
9aa74d7
to
5a7b8cd
Compare
Reference:
I wonder if it makes sense to deprecate the GMP random functions as
gmp_random()
was deprecated during the 7.X release cycle (we should then also deprecate thegmp_random_seed()
function)