Generate ext/spl methodsynopses based on stubs #624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Girgias
requested changes
Jun 18, 2021
There was a problem hiding this comment.
Common issue is that if the return type of a function changes then this its section usually needs updating, either that or the stubs are wrong.
ArrayObject/ArrayIterator is a mess because of the whole sort functions and ArrayAccess interface shenanigans so it might make sense to split this part of.
Otherwise, except where comments are LGTM.
|
I've just incorporated our latest stub fixes. @Girgias can you please take another look? |
Girgias
requested changes
Aug 11, 2021
| @@ -8,7 +8,7 @@ | |||
| <refsect1 role="description"> | |||
| &reftitle.description; | |||
| <methodsynopsis> | |||
| <modifier>public</modifier> <type>string</type> <methodname>DirectoryIterator::key</methodname> | |||
| <modifier>public</modifier> <type class="union"><type>int</type><type>false</type></type><methodname>DirectoryIterator::key</methodname> | |||
There was a problem hiding this comment.
I don't think it can be false, it either throws or returns an int, must have returned false prior to throwing
Girgias
approved these changes
Aug 11, 2021
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.