Fix #81331: compile errors ibm_db2.c v2.1.3 on Windows #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of PHP 7.4.0, the fallback definition of `ulong` has been removed from php-src[1]. This is usually not an issue on POSIX systems where `ulong` is pre-defined, but on Windows and some macOS environments, where it is not. We simply replace `ulong` with `unsigned long` for best compatibility. [1] <php/php-src#3905>
|
Hmmmm, I think these should be
|
These should actually be `zend_long`, not `ulong`. `num_idx` in `_php_db2_parse_options` is unused, so we remove the variable altogether.
|
I've just updated the PR according to your comment. Note that I can't test; actually, I cannot even build the extension. |
NattyNarwhal
approved these changes
Aug 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of PHP 7.4.0, the fallback definition of
ulonghas been removedfrom php-src[1]. This is usually not an issue on POSIX systems where
ulongis pre-defined, but on Windows and some macOS environments,where it is not.
We simply replace
ulongwithunsigned longfor best compatibility.[1] php/php-src#3905