Skip to content

Remove unused Git attributes ident #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

petk
Copy link
Member

@petk petk commented Jun 30, 2018

The $Id$ keywords were used in Subversion where they can be substituted
with filename, last revision number change, last changed date, and last
user who changed it.

In Git this functionality is different and can be done with Git attribute
ident. These need to be defined manually for each file in the
.gitattributes file and are afterwards replaced with 40-character
hexadecimal blob object name which is based only on the particular file
contents.

This patch simplifes handling of $Id$ keywords by removing them since
they are not used anymore.

Thanks for considering merging this or checking it out.

The $Id$ keywords were used in Subversion where they can be substituted
with filename, last revision number change, last changed date, and last
user who changed it.

In Git this functionality is different and can be done with Git attribute
ident. These need to be defined manually for each file in the
.gitattributes file and are afterwards replaced with 40-character
hexadecimal blob object name which is based only on the particular file
contents.

This patch simplifes handling of $Id$ keywords by removing them since
they are not used anymore.
@marinesovitch
Copy link
Contributor

Thank you for contribution. Your pull request will be merged to trunk in our internal infrastructure repo. It will be included in the next version (8.0.13) in about 3 months, because the current one (8.0.12) is already at 'code freeze' stage, and only critical patches are allowed.

@marinesovitch
Copy link
Contributor

The patch was applied in our internal repo, and in the end the it will be available with 8.0.12 yet (on the occasion of few other fixes). Push to github repo is expected soon.

@petk
Copy link
Member Author

petk commented Oct 6, 2018

Hello, any update here?

@petk
Copy link
Member Author

petk commented Oct 7, 2018

I guess this is committed in the repo then via 5d8a201 🎉 Closing as resolved. Thanks.

@petk petk closed this Oct 7, 2018
@petk petk deleted the patch-git-idents branch October 7, 2018 03:29
@marinesovitch
Copy link
Contributor

Yes, it was merged to master branch about 3 months ago, and U R also within list of contributors already. Sorry for not sending any notice. Meanwhile we've learned some things about github, next time we will merge pull-requests in other way, and more efficiently :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants