Add PHP 7.0 - 7.3 on Travis CI #35
Conversation
|
Hm, I assumed due to presence of a .travis.yml that https://travis-ci.org/php/pecl-networking-ssh2 would be an active build. Is this something an admin would like to enable? Are you building this code on a different build/test service? |
|
CC @langemeijer @remicollet ☝️ |
|
I added the |
|
@langemeijer merged the Travis CI config file but didn't enable Travis CI for the repo, which isn't a useful combination. Strongly request enabling the service. |
|
I've enabled Travis for this repository. Will leave merging this to a maintainer... |
|
Tests passing on all versions of PHP 7.x! |
.travis.yml
Outdated
| @@ -1,8 +1,11 @@ | |||
| sudo: required | |||
There was a problem hiding this comment.
- sudo: requiredTravis is deprecating the sudo keyword and moves everything to the same infrastructure (sudo really selects between two infrastructures).
See: https://blog.travis-ci.com/2018-11-19-required-linux-infrastructure-migration
| @@ -1,8 +1,11 @@ | |||
| sudo: required | |||
| dist: trusty | |||
| dist: xenial | |||
There was a problem hiding this comment.
- dist: xenialI think you can remove dist at all
There was a problem hiding this comment.
xenial is default now https://docs.travis-ci.com/user/reference/overview/#linux
There was a problem hiding this comment.
xenial has no 7.3 support on travis https://docs.travis-ci.com/user/reference/xenial/#php-support
So it should switch to bionic and drop 7.0 https://docs.travis-ci.com/user/reference/bionic/#php-support
There was a problem hiding this comment.
you can use different dist per versions. this example uses different dist for 5.3:
There was a problem hiding this comment.
however, you linked doc says:
The following PHP versions are preinstalled
it doesn't mean the other versions are not supported, they just are downloaded on demand. at least I've seen downloading x.y version messages in build logs.
|
Is there a way to create new release? Trying to package extension to Alpinelinux without success alpinelinux/aports#6226 |
|
I would also be interested in a new release. Is there anything anyone, including myself, can do to make it happen? |
|
And it still require #36 for 7.3 compatibility |
|
btw, can someone update pecl |
|
also, can someone push tags for created releases? so far only some legacy tags are present:
if needed I can dig up the commit hashes for someone to create lightweight tags. as I'm trying to build this for php 7.3, and apparently applying only #36 is not enough, and not known what is the baseline from the last release as git tags are missing from the repository. |
Also switch distribution from Trusty to Xenial as mentioned here travis-ci/travis-ci#9717 (comment)