PhD generates garbled chm on PHP 5.4.0 or later. #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjori
added a commit
that referenced
this pull request
Dec 29, 2013
PhD generates garbled chm on PHP 5.4.0 or later. * mumumu/fix_garbled_chm_on_php5_4_0_or_later: - fixed bug PhD generates garbled chm on PHP 5.4.0 or later.
|
I'm so sorry, I never saw this PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PhD generates garbled chm on PHP 5.4.0 or later, because of htmlspecialchars spec change (newly supports some encodings, CP932 and the default value for the encoding parameter was changed to UTF-8).
http://php.net/manual/en/function.htmlspecialchars.php
This issue cannot be reproduced on PHP 5.3.x.
How reproducible
Always on PHP 5.4.x, PHP 5.5.0
How to reproduce
Expected result
In the following files, the valeu of "name (<param name="Name" value="...">) is not empty. not garbled.
output/php-chm/php_manual_ja.hhc
output/php-chm/php_manual_ja.hhk
Actual Result
In the following files, the valeu of "name (<param name="Name" value="...">) is empty.
this is because htmlspecialchars function's return value is empty by specifying default encoding.
output/php-chm/php_manual_ja.hhc
output/php-chm/php_manual_ja.hhk
Suggesting fix
Pull request's source.
We should specify htmlspecialchars third parameter (encoding) with preferred_charset.
Extended Notes
This fix emits E_NOTICE in some locale on PHP 5.3.x, because 'CP932' and some encodings are not supported on htmlspecialchars on PHP 5.3.x. But this is not affected because PHP 5.3.x fallback to ISO-8859-1.