Fix 7930 #192
Closed
Fix 7930 #192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Neither the RFC nor this PR mentions how this interacts with https://wiki.php.net/rfc/list_keys but your test case in php/php-src#2371 does test for |
|
Yes I can add it to the spec change. Can't believe I forgot to note that in the RFC, it was accounted for during implementation in tests. |
|
php/php-src#2371 has been merged as php/php-src@6d4de4c. This PR for the langspec is able to be merged at this point to reflect the new syntax. |
cmb69
reviewed
Aug 29, 2018
|
Thanks! It occurs to me that #221 should be resolved before merging this PR. |
|
Merged as ee9565c, together with a tweak to the grammar to add the optional |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change was proposed, and accepted, via: https://wiki.php.net/rfc/list_reference_assignment