ext/iconv: Build fix for illumos distributions and solaris

close GH-18933

Author: Jacob Adams

NEWS

@@ -34,6 +34,9 @@ PHP                                                                        NEWS
   . Fixed GH-8157 (post_max_size evaluates .user.ini too late in php-fpm).
     (Jakub Zelenka)
 
+- Iconv:
+  . Extends the ICONV_CONST preprocessor for illumos/solaris. (jMichaelA)
+
 - Opcache:
   . Fixed bug GH-19669 (assertion failure in zend_jit_trace_type_to_info_ex).
     (Arnaud)

ext/iconv/iconv.c

@@ -43,7 +43,7 @@
 #undef iconv
 #endif
 
-#if defined(__NetBSD__)
+#if defined(__NetBSD__) || (defined(__sun) && defined(__SVR4))
 // unfortunately, netbsd has still the old non posix conformant signature
 // libiconv tends to match the eventual system's iconv too.
 #define ICONV_CONST const