iconv fix for illumos distributions #18933
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes I looked at it last night, was (pleasantly) surprised that |
|
Thanks devnexen. I made this for OmniOS, and I ran through a basic installation. Let me know if you have any questions that I can help with! |
|
The only question I would have .. should solaris have the same treatment ? solaris is still supported until 2027 I believe. |
|
|
|
@devnexen are you planning on merging this? |
|
well I asked RM opinion on this otherwise I ll wait post 8.5 |
DanielEScherzer
approved these changes
Sep 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extends the
ICONV_CONST constpreprocessor for iconv to illumos based distributions.