PHP fails to build with macOS libraries (for example ldap)

[SMillerDev]

Description

The following code:

https://github.com/Homebrew/homebrew-core/blob/4e4535e1612ecb88c24103bdefa11fa620162327/Formula/php@8.1.rb

    system "./configure", *args
    system "make"
    system "make", "install"

Resulted in this output:

  Undefined symbols for architecture arm64:
    "_ldap_create_passwordpolicy_control", referenced from:
        _zif_ldap_exop_passwd in ldap.o
    "_ldap_create_sort_control_value", referenced from:
        __php_ldap_controls_from_array in ldap.o
  Undefined symbols for architecture arm64:
    "_ldap_create_passwordpolicy_control", referenced from:
        _zif_ldap_exop_passwd in ldap.o
    "_ldap_create_vlv_control_value", referenced from:
        __php_ldap_controls_from_array in ldap.o
    "_ldap_create_sort_control_value", referenced from:
        __php_ldap_controls_from_array in ldap.o
    "_ldap_destroy", referenced from:
        _ldap_link_free_obj in ldap.o
        _zif_ldap_unbind in ldap.o
    "_ldap_create_vlv_control_value", referenced from:
        __php_ldap_controls_from_array in ldap.o
    "_ldap_destroy", referenced from:
        _ldap_link_free_obj in ldap.o
        _zif_ldap_unbind in ldap.o
    "_ldap_parse_passwordpolicy_control", referenced from:
        __php_ldap_controls_to_array in ldap.o
  Undefined symbols for architecture arm64:
    "_ldap_create_passwordpolicy_control", referenced from:
        _zif_ldap_exop_passwd in ldap.o
    "_ldap_parse_passwordpolicy_control", referenced from:
        __php_ldap_controls_to_array in ldap.o
    "_tidyLibraryVersion", referenced from:
        _zm_info_tidy in tidy.o
    "_ldap_create_sort_control_value", referenced from:
        __php_ldap_controls_from_array in ldap.o
    "_tidyLibraryVersion", referenced from:
        _zm_info_tidy in tidy.o
    "_ldap_create_vlv_control_value", referenced from:
        __php_ldap_controls_from_array in ldap.o
  ld: symbol(s) not found for architecture arm64
  ld: symbol(s) not found for architecture arm64
    "_ldap_destroy", referenced from:
        _ldap_link_free_obj in ldap.o
        _zif_ldap_unbind in ldap.o

But I expected this output instead:

I expected the build to succeed.

---

Homebrew currently carries a patch for this, which was submitted in #3472, but denied since PHP 7.4 used pkg config.

PHP Version

PHP 8.1.16

Operating System

macOS 13.2.1

[devnexen]

I can t reproduce whether I launch brew install php or directly the formula from the github repo :

 otool -L /opt/homebrew/bin/php
/opt/homebrew/bin/php:
	/opt/homebrew/opt/tidy-html5/lib/libtidy.58.dylib (compatibility version 58.0.0, current version 5.8.0)
	/usr/lib/libresolv.9.dylib (compatibility version 1.0.0, current version 1.0.0)
	/usr/lib/libncurses.5.4.dylib (compatibility version 5.4.0, current version 5.4.0)
	/opt/homebrew/opt/aspell/lib/libaspell.15.dylib (compatibility version 19.0.0, current version 19.1.0)
	/opt/homebrew/opt/aspell/lib/libpspell.15.dylib (compatibility version 19.0.0, current version 19.1.0)
	/opt/homebrew/opt/libpq/lib/libpq.5.dylib (compatibility version 5.0.0, current version 5.15.0)
	/opt/homebrew/opt/freetds/lib/libsybdb.5.dylib (compatibility version 7.0.0, current version 7.0.0)
	/opt/homebrew/opt/openldap/lib/libldap.2.dylib (compatibility version 3.0.0, current version 3.200.0)
	/opt/homebrew/opt/openldap/lib/liblber.2.dylib (compatibility version 3.0.0, current version 3.200.0)
...

[SMillerDev]

The formula has a patch for this, but it should probably be fixed in php

[devnexen]

What is passed to configure in the non patched version ?

[SMillerDev]

The arguments to configure don't change. The patch (which is visible at the end of the file) just forces a search in the system library directory in addition to /use/lib. We want to get rid of that patch in favour of properly fixing it upstream, hence the issue.

[carlocab]

To reproduce the failure, you need to make apply the patch below to "$(brew --repo homebrew/core)/Formula/php.rb", and then run

HOMEBREW_NO_INSTALL_FROM_API=1 brew install -s php

Patch:

diff --git a/Formula/php.rb b/Formula/php.rb
index cb8bdc65415..54d905a5813 100644
--- a/Formula/php.rb
+++ b/Formula/php.rb
@@ -62,12 +62,6 @@ class Php < Formula
   uses_from_macos "libxslt"
   uses_from_macos "zlib"
 
-  on_macos do
-    # PHP build system incorrectly links system libraries
-    # see https://github.com/php/php-src/pull/3472
-    patch :DATA
-  end
-
   def install
     # buildconf required due to system library linking bug patch
     system "./buildconf", "--force"
@@ -429,46 +423,3 @@ class Php < Formula
     end
   end
 end
-
-__END__
-diff --git a/build/php.m4 b/build/php.m4
-index 3624a33a8e..d17a635c2c 100644
---- a/build/php.m4
-+++ b/build/php.m4
-@@ -425,7 +425,7 @@ dnl
- dnl Adds a path to linkpath/runpath (LDFLAGS).
- dnl
- AC_DEFUN([PHP_ADD_LIBPATH],[
--  if test "$1" != "/usr/$PHP_LIBDIR" && test "$1" != "/usr/lib"; then
-+  if test "$1" != "$PHP_OS_SDKPATH/usr/$PHP_LIBDIR" && test "$1" != "/usr/lib"; then
-     PHP_EXPAND_PATH($1, ai_p)
-     ifelse([$2],,[
-       _PHP_ADD_LIBPATH_GLOBAL([$ai_p])
-@@ -470,7 +470,7 @@ dnl
- dnl Add an include path. If before is 1, add in the beginning of INCLUDES.
- dnl
- AC_DEFUN([PHP_ADD_INCLUDE],[
--  if test "$1" != "/usr/include"; then
-+  if test "$1" != "$PHP_OS_SDKPATH/usr/include"; then
-     PHP_EXPAND_PATH($1, ai_p)
-     PHP_RUN_ONCE(INCLUDEPATH, $ai_p, [
-       if test "$2"; then
-diff --git a/configure.ac b/configure.ac
-index 36c6e5e3e2..71b1a16607 100644
---- a/configure.ac
-+++ b/configure.ac
-@@ -190,6 +190,14 @@ PHP_ARG_WITH([libdir],
-   [lib],
-   [no])
-
-+dnl Support systems with system libraries/includes in e.g. /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.14.sdk.
-+PHP_ARG_WITH([os-sdkpath],
-+  [for system SDK directory],
-+  [AS_HELP_STRING([--with-os-sdkpath=NAME],
-+    [Ignore system libraries and includes in NAME rather than /])],
-+  [],
-+  [no])
-+
- PHP_ARG_ENABLE([rpath],
-   [whether to enable runpaths],
-   [AS_HELP_STRING([--disable-rpath],