Build of 8.2.7 fails on Alpinelinux

[andypost]

Description

Getting following error and warnings:

/bin/sh /builds/alpine/aports/community/php82/src/php-8.2.7/libtool --silent --preserve-dup-deps --tag CC --mode=compile clang -Iext/sysvmsg/ -I/builds/alpine/aports/community/php82/src/php-8.2.7/ext/sysvmsg/ -I/builds/alpine/aports/community/php82/src/php-8.2.7/include -I/builds/alpine/aports/community/php82/src/php-8.2.7/main -I/builds/alpine/aports/community/php82/src/php-8.2.7 -I/builds/alpine/aports/community/php82/src/php-8.2.7/ext/date/lib -I/usr/include/libxml2 -I/usr/include/enchant-2 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/libpng16 -I/usr/include/webp -I/usr/include/freetype2 -I/usr/include/imap -I/builds/alpine/aports/community/php82/src/php-8.2.7/ext/mbstring/libmbfl -I/builds/alpine/aports/community/php82/src/php-8.2.7/ext/mbstring/libmbfl/mbfl -I/usr/include/postgresql -I/usr/include/pspell -I/usr/include/editline -I/builds/alpine/aports/community/php82/src/php-8.2.7/TSRM -I/builds/alpine/aports/community/php82/src/php-8.2.7/Zend  -D_GNU_SOURCE -I/usr/include/imap  -fno-common -Wstrict-prototypes -Wall -Wextra -Wno-strict-aliasing -Wno-unused-parameter -Wno-sign-compare -O2 -fstack-clash-protection -Wformat -Werror=format-security -fno-plt -g -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -fvisibility=hidden -DZEND_SIGNALS   -prefer-pic  -DZEND_COMPILE_DL_EXT=1 -c /builds/alpine/aports/community/php82/src/php-8.2.7/ext/sysvmsg/sysvmsg.c -o ext/sysvmsg/sysvmsg.lo  -MMD -MF ext/sysvmsg/sysvmsg.dep -MT ext/sysvmsg/sysvmsg.lo
/builds/alpine/aports/community/php82/src/php-8.2.7/ext/soap/php_encoding.c:3417:21: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes]
void encode_reset_ns()
                    ^
                     void
/builds/alpine/aports/community/php82/src/php-8.2.7/ext/soap/php_encoding.c:3429:19: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes]
void encode_finish()
                  ^
                   void
/bin/sh /builds/alpine/aports/community/php82/src/php-8.2.7/libtool --silent --preserve-dup-deps --tag CC --mode=compile clang -Iext/sysvsem/ -I/builds/alpine/aports/community/php82/src/php-8.2.7/ext/sysvsem/ -I/builds/alpine/aports/community/php82/src/php-8.2.7/include -I/builds/alpine/aports/community/php82/src/php-8.2.7/main -I/builds/alpine/aports/community/php82/src/php-8.2.7 -I/builds/alpine/aports/community/php82/src/php-8.2.7/ext/date/lib -I/usr/include/libxml2 -I/usr/include/enchant-2 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/libpng16 -I/usr/include/webp -I/usr/include/freetype2 -I/usr/include/imap -I/builds/alpine/aports/community/php82/src/php-8.2.7/ext/mbstring/libmbfl -I/builds/alpine/aports/community/php82/src/php-8.2.7/ext/mbstring/libmbfl/mbfl -I/usr/include/postgresql -I/usr/include/pspell -I/usr/include/editline -I/builds/alpine/aports/community/php82/src/php-8.2.7/TSRM -I/builds/alpine/aports/community/php82/src/php-8.2.7/Zend  -D_GNU_SOURCE -I/usr/include/imap  -fno-common -Wstrict-prototypes -Wall -Wextra -Wno-strict-aliasing -Wno-unused-parameter -Wno-sign-compare -O2 -fstack-clash-protection -Wformat -Werror=format-security -fno-plt -g -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -fvisibility=hidden -DZEND_SIGNALS   -prefer-pic  -DZEND_COMPILE_DL_EXT=1 -c /builds/alpine/aports/community/php82/src/php-8.2.7/ext/sysvsem/sysvsem.c -o ext/sysvsem/sysvsem.lo  -MMD -MF ext/sysvsem/sysvsem.dep -MT ext/sysvsem/sysvsem.lo
/builds/alpine/aports/community/php82/src/php-8.2.7/ext/soap/php_http.c:675:5: error: call to undeclared function 'php_hash_bin2hex'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
                                php_hash_bin2hex(cnonce, nonce, sizeof(nonce));
                                ^
1 error generated.
make: *** [Makefile:2106: ext/soap/php_http.lo] Error 1

PHP Version

PHP 8.2.7

Operating System

Alpinelinux

[remicollet]

Cannot reproduce on Linux
This function is defined in ext/hash/php_hash.h which is properly included...

[remicollet]

ping
@nielsdos @bukka (authors)
@sgolemon @carusogabriel @ramsey @krakjoe @patrickallaert @adoy @saundefined (RMs)

[nielsdos]

I can take a look in the evening. It does look defined though. @andypost please tell me your compiler and the version you use.

[andypost]

Using clang 16.0.5 and the full log can be found at https://gitlab.alpinelinux.org/alpine/aports/-/jobs/1045326

[remicollet]

I suspect this may be related to "session" (which includes php_hash.h) being build shared.

https://github.com/remicollet/php-src/blob/master/ext/soap/php_soap.h#L26

#if defined(HAVE_PHP_SESSION) && !defined(COMPILE_DL_SESSION)
#include "ext/session/php_session.h"
#endif

And https://github.com/remicollet/php-src/blob/master/ext/session/php_session.h#L21

#include "ext/hash/php_hash.h"

[andypost]

@remicollet thank you! used your patch https://gitlab.alpinelinux.org/alpine/aports/-/blob/e53174768a58dbcb4ba16ab631d9afc15171770c/community/php82/fix-soap.patch and now tests running.. will update comment about result

[andypost]

btw does it mean that soap depends on session extension? Maybe kind of PHP_ADD_EXTENSION_DEP should be added to config.[m4/w32]?

[nielsdos]

No it doesn't depend on session.
What happened is that the function I used to write the digest in the SOAP fix, is a function from the ext/hash header.
The ext/hash function was not directly included, it was only included through the session header. However, if the session extension is built as a shared object, then the header include will not be performed...
The fix is adding a direct include for the ext/hash header.
I never noticed the problem because in the default configuration the session module is built statically instead of shared.

[andypost]

All tests passed! Thank you @nielsdos for elaboration