PCRE regular expressions with JIT enabled gives different result #11956

Activity

1. antman3351

   added

   Bug

   Status: Needs Triage

   on Aug 13, 2023
2. Girgias

   added

   Extension: pcre

   on Aug 13, 2023
3. ndossche commented on Aug 13, 2023

   

   ndossche

   on Aug 13, 2023

   Member

   More actions

   I can reproduce this locally. I'll run a bisect. This will also reveal if the problem is in PHP or in PCRE.
4. ndossche commented on Aug 13, 2023

   

   ndossche

   on Aug 13, 2023

   Last edited by ndossche

   Member

   More actions

   Bisect finished.

   It points to 5d42900 and 79755ca.
   This is indeed a pcre2lib problem in 2.37. Given that the pcre2lib maintainer says it does not reproduce in their testings on 2.42, I'd say the solution here is updating PHP's bundled pcre2lib to the latest version.

   As a temporary workaround you can configure & build with the flag to use your system's pcre2lib, and hope that version is high enough to not contain the bug.
5. ndossche

   added

   Status: Verified

   and removed

   Status: Needs Triage

   on Aug 13, 2023
6. hormus commented on Aug 21, 2023

   

   hormus

   on Aug 21, 2023

   Last edited by hormus

   More actions

   Or for compatibility

   $equal = preg_quote('=');
   $pattern = '/<(\\w+)[\\s\\w\\-]*id' . $equal . '"S44_i89ew">/';
   
   // or for other regex
   $equal = preg_quote('=');
   $pattern = '/<(\\w+)[\\s\\w\\-]*id' . $equal . '"S44_123">/';

   Pattern /<(\w+)[\s\w\-]+ id="S44_i89ew">/ not + but * and without white space id
   for subject  <br><div id="S44_i89ew">
   
7. antman3351 commented on Aug 21, 2023

   

   antman3351

   on Aug 21, 2023

   Author

   More actions

   Or for compatibility

   $equal = preg_quote('=');
   $pattern = '/<(\\w+)[\\s\\w\\-]*id' . $equal . '"S44_i89ew">/';
   
   // or for other regex
   $equal = preg_quote('=');
   $pattern = '/<(\\w+)[\\s\\w\\-]*id' . $equal . '"S44_123">/';
   

   Pattern /<(\w+)[\s\w\-]+ id="S44_i89ew">/ not + but * and without white space id
   for subject  <br><div id="S44_i89ew">
   

   Your regex doesn't cause the issue where there is a difference between JIT and non JIT.
8. ndossche

   self-assigned this

   on Sep 2, 2023
9. ndossche

   added a commit that references this issue on Sep 2, 2023

   Fix phpGH-11956: PCRE regular expressions with JIT enabled gives diff…

   ...

   This issue will close once commit aeb4c76 is merged into the 'master' branch.

   aeb4c76
10. ndossche

    linked a pull request that will close this issueFix GH-11956: PCRE regular expressions with JIT enabled gives different result #12108on Sep 2, 2023
11. ndossche

    added a commit that references this issue on Sep 18, 2023

    Fix GH-11956: PCRE regular expressions with JIT enabled gives differe…

    ...

    This issue will close once commit d61efdf is merged into the 'master' branch.

    d61efdf
12. ndossche

    closed this as completedin d61efdfon Sep 18, 2023
13. ndossche

    added 3 commits that reference this issue on Sep 18, 2023

    Merge branch 'PHP-8.1' into PHP-8.2

    ...

    This issue will close once commit 15bbae7 is merged into the 'master' branch.

    15bbae7

    Merge branch 'PHP-8.2' into PHP-8.3

    ...

    This issue will close once commit 1bed209 is merged into the 'master' branch.

    1bed209

    Merge branch 'PHP-8.3'

    ...

    This issue will close once commit 55432bf is merged into the 'master' branch.

    55432bf