gen_stub.php

[remicollet]

Using master branch (8.3.0-dev), gen_stub.php start using simple quote string (which is obviously bad in C)

Ex, using ecma_intl ext:

$ php build/gen_stub.php  -f
Saved ./src/php/ecma_intl_arginfo.h
$ git diff
...
-       zend_string *enum_case_Calendar_value_str = zend_string_init("calendar", strlen("calendar"), 1);
+       zend_string *enum_case_Calendar_value_str = zend_string_init('calendar', strlen('calendar'), 1);
...

[remicollet]

P.S. 8.3.0beta3 also affected

[remicollet]

@kocsismate help welcome on this one, may be related to nikic/php-parser v5 ?

[remicollet]

It seems gen_stub uses value as written in the stub.php, where single quotes are fine

A possible workaround is to use double quotes in stub, ex:

-        case Calendar = 'calendar';
+        case Calendar = "calendar";

[remicollet]

See PR #12064