PHP 8.3.0RC1 borked socket-close-on-exec.phpt

[andypost]

Description

The 8.3.0RC1 borked sapi/fpm/tests/socket-close-on-exec.phpt test on all arches

Resulted in this output:

TEST 16598/16667 [sapi/fpm/tests/socket-close-on-exec.phpt]
[1;31mBORK[0m 1	/bin/busybox	0	pipe:[2972692]
1	/bin/busybox	1	pipe:[2972693]
1	/bin/busybox	2	pipe:[2972694]
10	/bin/busybox	0	pipe:[2963005]
10	/bin/busybox	1	pipe:[2972693]
10	/bin/busybox	2	pipe:[2972694]
12	/bin/busybox	0	pipe:[2963005]
12	/bin/busybox	1	pipe:[2972693]
12	/bin/busybox	2	pipe:[2972694]
12	/bin/busybox	10	/usr/local/bin/build.sh
170	/bin/busybox	0	pipe:[2963005]
170	/bin/busybox	1	pipe:[2885237]
170	/bin/busybox	2	pipe:[2885237]
170	/bin/busybox	10	/usr/bin/abuild
171	/bin/busybox	0	pipe:[2885237]
171	/bin/busybox	1	pipe:[2972693]
171	/bin/busybox	2	pipe:[2972694]
174	/bin/busybox	0	pipe:[2885237]
174	/bin/busybox	1	pipe:[2972693]
174	/bin/busybox	2	pipe:[2972694]
174	/bin/busybox	3	/builds/alpine/aports/logs/build-php83.log
12096	/builds/alpine/aports/testing/php83/src/php-8.3.0RC1/sapi/cli/php	0	pipe:[3290469]
12096	/builds/alpine/aports/testing/php83/src/php-8.3.0RC1/sapi/cli/php	1	pipe:[3290470]
12096	/builds/alpine/aports/testing/php83/src/php-8.3.0RC1/sapi/cli/php	2	pipe:[3290471]
12096	/builds/alpine/aports/testing/php83/src/php-8.3.0RC1/sapi/cli/php	3	/builds/alpine/aports/testing/php83/src/php-8.3.0RC1/run-tests.php
12096	/builds/alpine/aports/testing/php83/src/php-8.3.0RC1/sapi/cli/php	4	/builds/alpine/aports/testing/php83/src/php-8.3.0RC1/sapi/fpm/tests/socket-close-on-exec.skip.php
12096	/builds/alpine/aports/testing/php83/src/php-8.3.0RC1/sapi/cli/php	5	pipe:[3289265]
23112	/usr/bin/make	0	pipe:[2963005]
23112	/usr/bin/make	1	pipe:[2885237]
23112	/usr/bin/make	2	pipe:[2885237]
23112	/usr/bin/make	3	/tmp/GMfifo23112
23112	/usr/bin/make	4	/tmp/GMfifo23112
23117	/bin/busybox	0	pipe:[2963005]
23117	/bin/busybox	1	pipe:[2885237]
23117	/bin/busybox	2	pipe:[2885237]
26037	/builds/alpine/aports/testing/php83/src/php-8.3.0RC1/sapi/cli/php	0	pipe:[2963005]
26037	/builds/alpine/aports/testing/php83/src/php-8.3.0RC1/sapi/cli/php	1	pipe:[2885237]
26037	/builds/alpine/aports/testing/php83/src/php-8.3.0RC1/sapi/cli/php	2	pipe:[2885237]
26037	/builds/alpine/aports/testing/php83/src/php-8.3.0RC1/sapi/cli/php	3	/builds/alpine/aports/testing/php83/src/php-8.3.0RC1/run-tests.php
26037	/builds/alpine/aports/testing/php83/src/php-8.3.0RC1/sapi/cli/php	6	pipe:[3290470]
26037	/builds/alpine/aports/testing/php83/src/php-8.3.0RC1/sapi/cli/php	8	pipe:[3290471] [sapi/fpm/tests/socket-close-on-exec.phpt] reason: invalid output from SKIPIF

But it was working in beta3, ref https://gitlab.alpinelinux.org/alpine/aports/-/merge_requests/50709

PHP Version

PHP 8.3.0RC1

Operating System

Alpinelinux

[andypost]

Locally getting the same problem

BORKED TEST SUMMARY
---------------------------------------------------------------------
1	/bin/busybox	0	/dev/pts/0
1	/bin/busybox	1	/dev/pts/0
1	/bin/busybox	2	/dev/pts/0
1	/bin/busybox	10	/dev/tty
417382	/bin/busybox	0	/dev/pts/0
417382	/bin/busybox	1	/dev/pts/0
417382	/bin/busybox	2	/dev/pts/0
417382	/bin/busybox	10	/usr/bin/abuild
417996	/usr/bin/make	0	/dev/pts/0
417996	/usr/bin/make	1	/dev/pts/0
417996	/usr/bin/make	2	/dev/pts/0
417996	/usr/bin/make	3	/tmp/GMfifo417996
417996	/usr/bin/make	4	/tmp/GMfifo417996
418001	/bin/busybox	0	/dev/pts/0
418001	/bin/busybox	1	/dev/pts/0
418001	/bin/busybox	2	/dev/pts/0
420921	/mnt/testing/php83/src/php-8.3.0RC1/sapi/cli/php	0	/dev/pts/0
420921	/mnt/testing/php83/src/php-8.3.0RC1/sapi/cli/php	1	/dev/pts/0
420921	/mnt/testing/php83/src/php-8.3.0RC1/sapi/cli/php	2	/dev/pts/0
420921	/mnt/testing/php83/src/php-8.3.0RC1/sapi/cli/php	3	/mnt/testing/php83/src/php-8.3.0RC1/run-tests.php
420921	/mnt/testing/php83/src/php-8.3.0RC1/sapi/cli/php	6	pipe:[83273124]
420921	/mnt/testing/php83/src/php-8.3.0RC1/sapi/cli/php	8	pipe:[83273125]
420927	/mnt/testing/php83/src/php-8.3.0RC1/sapi/cli/php	0	pipe:[83273123]
420927	/mnt/testing/php83/src/php-8.3.0RC1/sapi/cli/php	1	pipe:[83273124]
420927	/mnt/testing/php83/src/php-8.3.0RC1/sapi/cli/php	2	pipe:[83273125]
420927	/mnt/testing/php83/src/php-8.3.0RC1/sapi/cli/php	3	/mnt/testing/php83/src/php-8.3.0RC1/run-tests.php
420927	/mnt/testing/php83/src/php-8.3.0RC1/sapi/cli/php	4	/mnt/testing/php83/src/php-8.3.0RC1/sapi/fpm/tests/socket-close-on-exec.skip.php
420927	/mnt/testing/php83/src/php-8.3.0RC1/sapi/cli/php	5	pipe:[83275272] [/mnt/testing/php83/src/php-8.3.0RC1/sapi/fpm/tests/socket-close-on-exec.phpt]

[bukka]

Hmm looks like Alpine (Busybox) does support pid param in lsof by the look of it. Or is there support for that? If not, we should probably skip it...

[bukka]

Yeah I just tested it and seems like lsof does not accept any params on alpine (tested with nginx:alpine) and it always gives the same result no matter what I do

[andypost]

Thank you! It solved by installing lsof package https://pkgs.alpinelinux.org/contents?file=lsof&path=&name=&branch=edge

http://lists.busybox.net/pipermail/busybox/2020-February/087781.html I found no replies to add -p argument(

[bukka]

@andypost Can you also check this skip for version without proper lsof: #12084 ?

[andypost]

@bukka nice idea! it works, thank you

/mnt/testing/php83 $ TESTS='--show-diff sapi/fpm/tests/socket-close-on-exec.phpt' abuild check

Build complete.
Don't forget to run 'make test'.


=====================================================================
PHP         : /mnt/testing/php83/src/php-8.3.0RC1/sapi/cli/php 
PHP_SAPI    : cli
PHP_VERSION : 8.3.0RC1
ZEND_VERSION: 4.3.0RC1
PHP_OS      : Linux - Linux sd-92483 5.4.0-153-generic #170-Ubuntu SMP Fri Jun 16 13:43:31 UTC 2023 x86_64
INI actual  : /mnt/testing/php83/src/php-8.3.0RC1/tmp-php.ini
More .INIs  :  
---------------------------------------------------------------------
PHP         : /mnt/testing/php83/src/php-8.3.0RC1/sapi/cgi/php-cgi 
PHP_SAPI    : cgi-fcgi
PHP_VERSION : 8.3.0RC1
ZEND_VERSION: 4.3.0RC1
PHP_OS      : Linux - Linux sd-92483 5.4.0-153-generic #170-Ubuntu SMP Fri Jun 16 13:43:31 UTC 2023 x86_64
INI actual  : /mnt/testing/php83/src/php-8.3.0RC1/tmp-php.ini
More .INIs  : 
--------------------------------------------------------------------- 
---------------------------------------------------------------------
PHP         : /mnt/testing/php83/src/php-8.3.0RC1/sapi/phpdbg/phpdbg 
PHP_SAPI    : phpdbg
PHP_VERSION : 8.3.0RC1
ZEND_VERSION: 4.3.0RC1
PHP_OS      : Linux - Linux sd-92483 5.4.0-153-generic #170-Ubuntu SMP Fri Jun 16 13:43:31 UTC 2023 x86_64
INI actual  : /mnt/testing/php83/src/php-8.3.0RC1/tmp-php.ini
More .INIs  : 
---------------------------------------------------------------------
CWD         : /mnt/testing/php83/src/php-8.3.0RC1
Extra dirs  : 
VALGRIND    : Not used
=====================================================================
Running selected tests.
SKIP FPM: Set CLOEXEC on the listen and connection socket [sapi/fpm/tests/socket-close-on-exec.phpt] reason: command 'lsof -v' did not contain output 'lsof version information'
=====================================================================
Number of tests :     1                 0
Tests skipped   :     1 (100.0%) --------
Tests warned    :     0 (  0.0%) (  0.0%)
Tests failed    :     0 (  0.0%) (  0.0%)
Tests passed    :     0 (  0.0%) (  0.0%)
---------------------------------------------------------------------
Time taken      :     0 seconds
=====================================================================
NOTE: We have skipped quite a lot tests, see disabled-tests.list.
/mnt/testing/php83 $ doas apk add lsof
(1/1) Installing lsof (4.98.0-r2)
Executing busybox-1.36.1-r6.trigger
OK: 753 MiB in 277 packages
/mnt/testing/php83 $ TESTS='--show-diff sapi/fpm/tests/socket-close-on-exec.phpt' abuild check

Build complete.
Don't forget to run 'make test'.


=====================================================================
PHP         : /mnt/testing/php83/src/php-8.3.0RC1/sapi/cli/php 
PHP_SAPI    : cli
PHP_VERSION : 8.3.0RC1
ZEND_VERSION: 4.3.0RC1
PHP_OS      : Linux - Linux sd-92483 5.4.0-153-generic #170-Ubuntu SMP Fri Jun 16 13:43:31 UTC 2023 x86_64
INI actual  : /mnt/testing/php83/src/php-8.3.0RC1/tmp-php.ini
More .INIs  :  
---------------------------------------------------------------------
PHP         : /mnt/testing/php83/src/php-8.3.0RC1/sapi/cgi/php-cgi 
PHP_SAPI    : cgi-fcgi
PHP_VERSION : 8.3.0RC1
ZEND_VERSION: 4.3.0RC1
PHP_OS      : Linux - Linux sd-92483 5.4.0-153-generic #170-Ubuntu SMP Fri Jun 16 13:43:31 UTC 2023 x86_64
INI actual  : /mnt/testing/php83/src/php-8.3.0RC1/tmp-php.ini
More .INIs  : 
--------------------------------------------------------------------- 
---------------------------------------------------------------------
PHP         : /mnt/testing/php83/src/php-8.3.0RC1/sapi/phpdbg/phpdbg 
PHP_SAPI    : phpdbg
PHP_VERSION : 8.3.0RC1
ZEND_VERSION: 4.3.0RC1
PHP_OS      : Linux - Linux sd-92483 5.4.0-153-generic #170-Ubuntu SMP Fri Jun 16 13:43:31 UTC 2023 x86_64
INI actual  : /mnt/testing/php83/src/php-8.3.0RC1/tmp-php.ini
More .INIs  : 
---------------------------------------------------------------------
CWD         : /mnt/testing/php83/src/php-8.3.0RC1
Extra dirs  : 
VALGRIND    : Not used
=====================================================================
Running selected tests.
PASS FPM: Set CLOEXEC on the listen and connection socket [sapi/fpm/tests/socket-close-on-exec.phpt] 

[mikhainin]

Ouch, I just wanted to take a look into this but it seems already fixed.
Sorry for the disruption.