Show attribute name/class in ReflectionAttribute dump

[mvorisek]

Description

repro: https://3v4l.org/S6cUD

This is a feature request to dump the attribute name/class in ReflectionAttribute about the same as for ReflectionProperty.

---

workaround to dump attributes incl. properties: https://3v4l.org/Np0NP

[nielsdos]

This is super easy to implement:

diff --git a/ext/reflection/php_reflection.c b/ext/reflection/php_reflection.c
index 53e978604a..e272209d45 100644
--- a/ext/reflection/php_reflection.c
+++ b/ext/reflection/php_reflection.c
@@ -1122,6 +1122,7 @@ static void reflection_attribute_factory(zval *object, HashTable *attributes, ze
 	reference->target = target;
 	intern->ptr = reference;
 	intern->ref_type = REF_TYPE_ATTRIBUTE;
+	ZVAL_STR_COPY(reflection_prop_name(object), data->name);
 }
 /* }}} */
 
diff --git a/ext/reflection/php_reflection.stub.php b/ext/reflection/php_reflection.stub.php
index 06b5835810..41768b6f61 100644
--- a/ext/reflection/php_reflection.stub.php
+++ b/ext/reflection/php_reflection.stub.php
@@ -764,6 +764,8 @@ class ReflectionAttribute implements Reflector
     /** @cvalue REFLECTION_ATTRIBUTE_IS_INSTANCEOF */
     public const int IS_INSTANCEOF = UNKNOWN;
 
+    public string $name;
+
     public function getName(): string {}
     public function getTarget(): int {}
     public function isRepeated(): bool {}
diff --git a/ext/reflection/php_reflection_arginfo.h b/ext/reflection/php_reflection_arginfo.h
index 7683128694..141bc9ec14 100644
--- a/ext/reflection/php_reflection_arginfo.h
+++ b/ext/reflection/php_reflection_arginfo.h
@@ -1,5 +1,5 @@
 /* This is a generated file, edit the .stub.php file instead.
- * Stub hash: 11fcaa654fc0442e8338f6849b91aa2970b211b9 */
+ * Stub hash: 0adb92be59fadce74bb12017fe64ffbccab2a060 */
 
 ZEND_BEGIN_ARG_WITH_TENTATIVE_RETURN_TYPE_INFO_EX(arginfo_class_Reflection_getModifierNames, 0, 1, IS_ARRAY, 0)
 	ZEND_ARG_TYPE_INFO(0, modifiers, IS_LONG, 0)
@@ -1613,6 +1613,12 @@ static zend_class_entry *register_class_ReflectionAttribute(zend_class_entry *cl
 	zend_declare_typed_class_constant(class_entry, const_IS_INSTANCEOF_name, &const_IS_INSTANCEOF_value, ZEND_ACC_PUBLIC, NULL, (zend_type) ZEND_TYPE_INIT_MASK(MAY_BE_LONG));
 	zend_string_release(const_IS_INSTANCEOF_name);
 
+	zval property_name_default_value;
+	ZVAL_UNDEF(&property_name_default_value);
+	zend_string *property_name_name = zend_string_init("name", sizeof("name") - 1, 1);
+	zend_declare_typed_property(class_entry, property_name_name, &property_name_default_value, ZEND_ACC_PUBLIC, NULL, (zend_type) ZEND_TYPE_INIT_MASK(MAY_BE_STRING));
+	zend_string_release(property_name_name);
+
 	return class_entry;
 }
 

Note that this only implements the $name property because ReflectionAttribute also represents targets other than classes.
I don't know why the name property wasn't added when this class was introduced, especially considering that most other reflection classes have them and that it is useful in debugging.

[mvorisek]

I don't know why the name property wasn't added when this class was introduced, especially considering that most other reflection classes have them and that it is useful in debugging.

👍 this is consistent with ReflectionClass - https://3v4l.org/BaHd7

Also what about attribute arguments, can/should they be dumped too?

[nielsdos]

Also what about attribute arguments, can/should they be dumped too?

It is technically possible to dump them, albeit a bit harder because there isn't code I can reuse. And it would be a performance penalty too because right now we only instantiate objects when getArguments is called.
We don't dump e.g. properties in ReflectionClass either.

I would prefer to keep it at only the name: this has practically no performance impact and is already a big improvement.