Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect SCRIPT_NAME with apache ProxyPassMatch when a plus '+' is in path #12996

Closed
mrAceT opened this issue Dec 21, 2023 · 2 comments
Closed
Assignees

Comments

@mrAceT
Copy link

mrAceT commented Dec 21, 2023

Description

do you remember:
#10869

I copied the title.. and replaced the 'space' with a 'plus' ( + ).

I had the same naging problem in my NextCloud instance when spaces were in file names the whole darn thing went the way of the dino..

And I thought of a "Q&D" way to get around that bug.. which turned out to NOT be a NextCloud bug, but a PHP 8.1 bug..

After updating PHP to 8.1.18 my "Q&D fix" wasn't needed anymore and I removed that piece of code..

If only I kept it in.. as it turns out an other (less often occurring) bug became more and more irritating.. the 'plus sign'

I have searched in all kinds of directions.. never thinking of the "space bug".. but there was the solution (one I wrote myself..)

Long story short: could you implement a "version 2" fix of the "space bug" for the "plus bug" ?

ref: nextcloud/server#40943

PHP Version

PHP 8.1.27

Operating System

AlmaLinux 8.9 (Midnight Oncilla)

bukka added a commit to bukka/php-src that referenced this issue Jan 4, 2024
bukka added a commit to bukka/php-src that referenced this issue Jan 4, 2024
@bukka
Copy link
Member

bukka commented Jan 4, 2024

Fix in #13072

@bukka bukka closed this as completed in b04b09e Jan 11, 2024
@mrAceT
Copy link
Author

mrAceT commented Mar 14, 2024

For those who find this page.. it is fixed in PHP 8.2

If you are running al lower version (that includes ALL PHP 8.1 (and lower?) versions..) Then you will still need my Q&D fix..

I just found that out after my latest update to NextCloud 27.1.x ..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants