Remove incorrect uses of zval_ptr_dtor #19162
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimWolla
reviewed
Jul 17, 2025
nielsdos
added a commit
that referenced
this pull request
Jul 17, 2025
* PHP-8.3: NEWS for GH-19162 ext/socket: Remove incorrect zval_ptr_dtor ext/hash: Remove incorrect zval_ptr_dtor
nielsdos
added a commit
that referenced
this pull request
Jul 17, 2025
* PHP-8.4: NEWS for GH-19162 ext/socket: Remove incorrect zval_ptr_dtor ext/hash: Remove incorrect zval_ptr_dtor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
zval_ptr_dtor followed by RETURN_THROWS is always wrong, unless the return value is overwritten in between. That's because the VM will already destroy the zval, leading to double destroying it.