Skip to content

uri: Clean up naming of public symbols #19794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Sep 11, 2025
Merged

uri: Clean up naming of public symbols #19794

merged 11 commits into from
Sep 11, 2025

Conversation

TimWolla
Copy link
Member

This PR cleans up the names of various public symbols in ext/uri:

  • Consistently use php_uri_ as the prefix.
  • Match the enum field names with the enum name itself.
  • Do not use the reserved _t suffix.
  • Shorten various names where the context is implied.

@TimWolla
uri: Rename uri_recomposition_mode_t to php_uri_recomposition_mode
b6fe680
@TimWolla
uri: Align the names of the php_uri_recomposition_mode values
8cc3627
@TimWolla
uri: Rename uri_component_read_mode_t to php_uri_component_read_mode
8e97bdc
@TimWolla
uri: Align the names of the php_uri_component_read_mode values
23d9c58
@TimWolla
uri: Rename uri_property_name_t to php_uri_property_name
825a3fc
@TimWolla
uri: Align the names of the php_uri_property_name values
498fa27
@TimWolla
uri: Rename uri_property_handler_t to php_uri_property_handler
bd30fec
@TimWolla
uri: Rename uri_(read|write)_t to `php_uri_property_handler_(read|w…
9f66431 
…rite)`
@TimWolla
uri: Rename php_uri_property_handler’s (read|write)_func to `read…
5da6214 
…|write`

The `_func` is implied by the data type and the name of the struct.
@TimWolla
uri: Rename uri_parser_t to php_uri_parser
9557ba0
@TimWolla
uri: Shorten the names of php_uri_parser fields
69b077e 
The `_uri` suffix is implied, because this is an URI parser.
@TimWolla TimWolla requested a review from a team September 10, 2025 22:05
kocsismate
kocsismate approved these changes Sep 11, 2025
View reviewed changes
Copy link
Member

@kocsismate kocsismate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

edorian
edorian approved these changes Sep 11, 2025
View reviewed changes
Copy link
Member

@edorian edorian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RM approval 👍. No technical review performed.

@TimWolla TimWolla merged commit 26eac7d into php:master Sep 11, 2025
9 checks passed
@TimWolla TimWolla deleted the uri-naming branch September 11, 2025 10:10
TimWolla added a commit that referenced this pull request Sep 12, 2025
@TimWolla
uri: NEWS for GH-19794, GH-19768, and others
e6c6333
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edorian edorian edorian approved these changes

@kocsismate kocsismate kocsismate approved these changes

@bukka bukka Awaiting requested review from bukka bukka is a code owner

@nielsdos nielsdos Awaiting requested review from nielsdos nielsdos is a code owner

Assignees
No one assigned
Labels
ABI break Extension: filter Extension: openssl Extension: soap Extension: standard Extension: uri Extension: zend_test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TimWolla @edorian @kocsismate