Flaky tests triage

[hakre]

Need to untangle a couple of flaky test fixes that I prematurely put onto master as they matched up the error picture, but they need to be split onto different PR with different base branches as they are .phpt test cases.

• Patch #20028 Flaky tests on PHP-8.5 #20031
• Patch #20028 Flaky tests on PHP-8.3 #20035

PHP Version

• 8.5
• 8.3

Operating System

Generic Linux

Additional Info

Originally based on master from #18286

Docs: RunningTests: docs/source/miscellaneous/running-tests.rst

[iluuu1994]

What is this in reference to?

[hakre]

What is this in reference to?

I have to split up a patch-set for flaky tests that I fixed locally but put on a wrong branch/PR (too crowded) and needed an issue number for that. Will keep the issue description updated with the references as I add them. @iluuu1994

[hakre]

If you like you can assign me to this issue then it's probably more clear that I have to file the appropriate PRs and it would help me to organize. Thank you! @iluuu1994

[hakre]

All flaky test fixes are now distributed on their own pull requests.

There are two:

1. Patch #20028 Flaky tests on PHP-8.3 #20035 based against PHP-8.5, and
2. Patch #20028 Flaky tests on PHP-8.5 #20031 based against PHP-8.3, the current last green/supported release branch.

There is one duplicate path, ext/date/tests/multiple_calls_date_period_iterator_current.phpt, both in 8.3: 5d4f935 / #20035 and 8.5: 6c882a6 / #20031.

The change is identical (lines 5+6), so merging #20035 into PHP-8.3 and then merging the rebase of #20031 into PHP-8.5 should be straight forward.

Listing of Pull Requests

• Patch 20028 8.5 Patch #20028 Flaky tests on PHP-8.5 #20031
• Patch 20028 8.3 Patch #20028 Flaky tests on PHP-8.3 #20035

Listing of Affected Files

• Zend/tests/inheritance/deprecation_to_exception_during_inheritance_can_be_caught.phpt
• ext/date/tests/multiple_calls_date_period_iterator_current.phpt
• ext/standard/tests/mail/gh19188_cr_lf_mode.phpt
• ext/standard/tests/mail/gh19188_mixed_mode.phpt
• ext/standard/tests/mail/gh19188_os_mode_unix.phpt
• ext/standard/tests/mail/gh8086.phpt
• sapi/cgi/tests/auto_globals_no_jit.phpt
• sapi/cli/tests/php_cli_server_ipv4_error_message.phpt

Listing of Commits

• 974b7ea - Fix flaky variables order - Fix is to set variables_order to ES.
• 580c9e3 - Fix flaky extra mail header (Mail: introduce new INI for line ending control #19188) - Fix is to set mail.add_x_header to off.
• 6c882a6 - Fix flaky timezone test fixture - Fix is to interpolate the timezone in the test fixture or to set date.timezone to UTC.
• 57d9b20 - Fix flaky extra mail header (Mail() function not working correctly in PHP 8.x #8086) - Fix is to set mail.add_x_header to off.
• fb2700b - Fix flaky timezone test fixture (Fix leaks with multiple calls to DatePeriod iterator current() #18624) - Fix is to interpolate the timezone in the test fixture or to set date.timezone to UTC.
• 5d4f935 - Fix flaky logging test - Fix is to set the directive on the command line (set log_errors to 0).

Table of Directives

Directive	Flaky with	Flaky for
mail.add_x_header	On	Off
date.timezone	Europe/Berlin	UTC
variables_order	GPCS	ES
log_errors	On	Off