8.5 MSVC compilation error on `ext/intl`

[nono303]

Description

Hi
Trying to compile 8.5 (53b0a95) under MSVC x64 (vs17 & vs18)
🔴 I have errors on ext\intl\locale\locale_methods.cpp:

ext\intl\locale\locale_methods.cpp(525): error C2664: 'void get_icu_value_src_php(char *,zend_execute_data *,zval *)' : impossible de convertir l'argument 1 de 'const char [7]' en 'char *'

✅ adding /Zc:strictStrings- to CFLAGS_BD_EXT_INTL_LOCALE resolve the compilation issue and give a working build (against icu 78.1)

See full cmd line and failing result

PHP Version

PHP 8.5.0-dev (cli) (built: Oct  8 2025 14:47:36) (ZTS MSVC 19.50.35503, untested x64)
Copyright (c) The PHP Group
Zend Engine v4.5.0-dev, Copyright (c) Zend Technologies
    with Zend OPcache v8.5.0-dev, Copyright (c), by Zend Technologies

Operating System

Windows 11 x64

[devnexen]

Hi would you mind creating a PR ? I guess the flag has to go somewhere in ext/intl/config.w32

[nono303]

I can make a PR but not sure that shutting down strictStrings is the good solution?

[devnexen]

maybe fixing the signature might be the appropriate solution but anyway feel free to open a PR ;)

[nono303]

Digging a little bit more on /ext/intl/config.w32, there is a specific CFLAG for this module: /std:c++17 which was silently overridden by my latest MSCV compiler (vs18), changed to /std:c++latest
Downgrading compiler version and checking that no override of the flag is done, there is no error.

To summarize
✅ /std:c++17 (current config.w32) works but might cause trouble for next compiler version (19.50 aka vs18 which is currently only available for insiders)
🔴 /std:c++latest failed
✅ /std:c++latest /Zc:strictStrings- works
🔴 Removing completely /std flag failed

C:\sdk\release\vs18_x64-avx2\include\unicode/uversion.h(183): error C2429: fonctionnalité de langage 'nested-namespace-definition' exige l'indicateur de compilateur '/std:c++17' (compilation du fichier source ext\intl\locale\locale_class.cpp)
C:\sdk\release\vs18_x64-avx2\include\unicode/uversion.h(183): error C2429: fonctionnalité de langage 'nested-namespace-definition' exige l'indicateur de compilateur '/std:c++17' (compilation du fichier source ext\intl\locale\locale_methods.cpp)

I’ve just quickly checked and intl is the only ext "forcing" the /std flag with a hardcoded version - which might be problematic when building it against older or newer compiler, as said.

[devnexen]

To summarize ✅ /std:c++17 (current config.w32) works but might cause trouble for next compiler version (19.50 aka vs18 which is currently only available for insiders)

I am curious which issue you are referring to, ideally when set a C++ standard updating the compiler should not cause problems (ideally ..).

🔴 /std:c++latest failed ✅ /std:c++latest /Zc:strictStrings- works 🔴 Removing completely /std flag failed

C:\sdk\release\vs18_x64-avx2\include\unicode/uversion.h(183): error C2429: fonctionnalité de langage 'nested-namespace-definition' exige l'indicateur de compilateur '/std:c++17' (compilation du fichier source ext\intl\locale\locale_class.cpp)
C:\sdk\release\vs18_x64-avx2\include\unicode/uversion.h(183): error C2429: fonctionnalité de langage 'nested-namespace-definition' exige l'indicateur de compilateur '/std:c++17' (compilation du fichier source ext\intl\locale\locale_methods.cpp)

I’ve just quickly checked and intl is the only ext "forcing" the /std flag with a hardcoded version - which might be problematic when building it against older or newer compiler, as said.

For the unixes version, it is either c++11 or c++17 depending on the compiler support, maybe it is/was not possible to do the same for Windows ? No time to really look at it but feel free to expand on the above points. Cheers.

[nono303]

not the same options for C & C++
Available C++ Standard Version in MSVC22

/std:c++14
/std:c++17
/std:c++20
/std:c++23preview
/std:c++latest

Available C Standard Version in MSVC22

/std:c11
/std:c17
/std:clatest

[devnexen]

not the same options for C & C++ Available C++ Standard Version in MSVC22

/std:c++14
/std:c++17
/std:c++20
/std:c++23preview
/std:c++latest

Available C Standard Version in MSVC22

/std:c11
/std:c17
/std:clatest

std:c++ flag only apply to C++ and yes it is expected to have different options for both languages they have each independent standards updates. I do not get really your concern about To summarize ✅ /std:c++17 (current config.w32) works but might cause trouble for next compiler version though.