Incorrect return types for hash() and hash_hmac() #7759
Assignees
Labels
Comments
|
Good catch! Thank you! |
cmb69
added a commit
to cmb69/php-src
that referenced
this issue
Dec 11, 2021
`hash()` and `hash_hmac()` never return `false`; only `hash_file()` and `hash_hmac_file()` return `false` in case the data cannot be read.
cmb69
added a commit
that referenced
this issue
Dec 12, 2021
* PHP-8.0: Fix GH-7759: Incorrect return types for hash() and hash_hmac()
cmb69
added a commit
that referenced
this issue
Dec 12, 2021
* PHP-8.1: Fix GH-7759: Incorrect return types for hash() and hash_hmac()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
and others
Description
I believe the stub file entries for
hash()andhash_hmac()to be incorrect. Their return types are both specified asstring|false, but starting with PHP 8.0 they in fact never returnfalse, they throw a fatal error where they returnedfalsebefore PHP 8.0. In the case ofhash()the only twoRETURN_FALSEstatements (1, 2) are withinif (isfilename)blocks, e.g. the code path used exclusively byhash_file(). It's similar forhash_hmac().Does that make sense or did I miss something?
PHP Version
PHP >= 8.0
Operating System
All OSes
The text was updated successfully, but these errors were encountered: