Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent argument name in hash-hmac-file and hash-file #7826

Closed
Rotzbua opened this issue Dec 25, 2021 · 3 comments
Closed

Inconsistent argument name in hash-hmac-file and hash-file #7826

Rotzbua opened this issue Dec 25, 2021 · 3 comments

Comments

@Rotzbua
Copy link

Rotzbua commented Dec 25, 2021

From manual page: https://php.net/function.hash-hmac-file


string $data, should be string $filename, to have the same naming scheme as hash-file().

@cmb69
Copy link
Contributor

cmb69 commented Dec 25, 2021

Oh, right, but that would need to be fixed in php-src first, and would be a BC break.

@cmb69 cmb69 transferred this issue from php/doc-en Dec 25, 2021
cmb69 added a commit to cmb69/php-src that referenced this issue Dec 25, 2021
…_file

Like `hash_file()`, `hash_hmac_file()` expects a filename, and not some
string data.  Fixing this now, constitutes a (hopefully small) BC break
though.
@cmb69 cmb69 added the Bug label Dec 25, 2021
cmb69 added a commit that referenced this issue Dec 26, 2021
* PHP-8.0:
  Fix GH-7826: Inconsistent argument name in hash_hmac_file and hash_file
@cmb69 cmb69 closed this as completed in fd3fc5c Dec 26, 2021
cmb69 added a commit that referenced this issue Dec 26, 2021
* PHP-8.1:
  Fix GH-7826: Inconsistent argument name in hash_hmac_file and hash_file
cmb69 added a commit to php/doc-en that referenced this issue Dec 26, 2021
@cmb69
Copy link
Contributor

cmb69 commented Dec 26, 2021

Documented via php/doc-en@1adf246

@Rotzbua
Copy link
Author

Rotzbua commented Dec 26, 2021

@cmb69 Thanks 👍

tiffany-taylor pushed a commit to tiffany-taylor/doc-en that referenced this issue Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants
@cmb69 @Rotzbua and others