Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

php_admin_value[extension] = ext.so in fpm config does not register module handlers #9921

Closed
bwoebi opened this issue Nov 10, 2022 · 0 comments
Assignees

Comments

@bwoebi
Copy link
Member

bwoebi commented Nov 10, 2022

Description

Specifying php_admin_value[extension] = ext.so in fpm config will execute MINIT, then RINIT of a PHP module. But it won't execute RSHUTDOWN and post_deactivate handlers (as these aren't collected). Also it won't execute RINIT on any subsequent requests after the first one.

This might be acceptable in the case of dl() in CLI processes handling only one request, but in php-fpm it will just carry along.

This leads to all sorts of interesting misbehaviours.

PHP Version

PHP 5.4 - master

bwoebi added a commit to DataDog/dd-trace-php that referenced this issue Nov 10, 2022
See also php/php-src#9921 - loading profiler in fpm config may crash (currently we observe concrete crashes due to zai config not being re-initialized correctly)

Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
morrisonlevi added a commit to DataDog/dd-trace-php that referenced this issue Nov 14, 2022
* Add .ini support in profiling

* Display INIs in profiler MINFO

Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>

* Also update decoded_values of original MINIT for shared configs on add

Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>

* Fix some potential string issues

* Fix test from port default change from 8126 to 0

* Add profiling .ini templates

* Always load extensions via ini

See also php/php-src#9921 - loading profiler in fpm config may crash (currently we observe concrete crashes due to zai config not being re-initialized correctly)

Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>

* [ci skip] Bump profiling version to 0.11.0

Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
Co-authored-by: Bob Weinand <bob.weinand@datadoghq.com>
agoallikmaa pushed a commit to agoallikmaa/signalfx-php-tracing that referenced this issue Jan 5, 2023
* Add .ini support in profiling

* Display INIs in profiler MINFO

Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>

* Also update decoded_values of original MINIT for shared configs on add

Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>

* Fix some potential string issues

* Fix test from port default change from 8126 to 0

* Add profiling .ini templates

* Always load extensions via ini

See also php/php-src#9921 - loading profiler in fpm config may crash (currently we observe concrete crashes due to zai config not being re-initialized correctly)

Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>

* [ci skip] Bump profiling version to 0.11.0

Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
Co-authored-by: Bob Weinand <bob.weinand@datadoghq.com>
bukka added a commit to bukka/php-src that referenced this issue Oct 7, 2023
bukka added a commit to bukka/php-src that referenced this issue Oct 7, 2023
bukka added a commit to bukka/php-src that referenced this issue Nov 2, 2023
@bukka bukka closed this as completed in a8c6c61 Nov 3, 2023
@bukka bukka self-assigned this Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants