Skip to content

Fix #81742: open_basedir bypass in SQLite3 by using file URI #10018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Fix #81742: open_basedir bypass in SQLite3 by using file URI #10018

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
28ae0c4
Fix #81742: open_basedir bypass in SQLite3 by using file URI
cmb69 Nov 29, 2022
4be441c
Remove superfluous check
cmb69 Dec 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions ext/sqlite3/sqlite3.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2040,14 +2040,8 @@ static int php_sqlite3_authorizer(void *autharg, int action, const char *arg1, c
if (memcmp(arg1, ":memory:", sizeof(":memory:")) && *arg1) {
if (strncmp(arg1, "file:", 5) == 0) {
/* starts with "file:" */
if (!arg1[5]) {
return SQLITE_DENY;
}
if (php_check_open_basedir(arg1 + 5)) {
return SQLITE_DENY;
}
}
if (php_check_open_basedir(arg1)) {
return SQLITE_DENY;
} else if (php_check_open_basedir(arg1)) {
return SQLITE_DENY;
}
}
Expand Down
13 changes: 13 additions & 0 deletions ext/sqlite3/tests/bug81742.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
--TEST--
Bug #81742 (open_basedir bypass in SQLite3 by using url encoded file)
--EXTENSIONS--
sqlite3
--INI--
open_basedir=.
--FILE--
<?php
$db = new SQLite3(':memory:');
$db->query("ATTACH 'file:..%2ffoo.php' as db2;");
?>
--EXPECTF--
Warning: SQLite3::query(): not authorized in %s on line %d