Lsapi ndef #1014
Closed
Lsapi ndef #1014
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -3112,6 +3114,10 @@ static int lsapi_initSuEXEC() | |||
| if ( !s_defaultUid || !s_defaultGid ) | |||
| { | |||
| pw = getpwnam( "nobody" ); | |||
| if(!pw) { | |||
| perror( "Can't get uid for user 'nobody'" ); | |||
There was a problem hiding this comment.
Fixed.
In nano, the indenting they use shows as the same as a tab.
| if ( !pReq || !name ) | ||
| return NULL; | ||
|
|
||
| struct LSAPI_key_value_pair * pBegin = pReq->m_pEnvList; |
There was a problem hiding this comment.
This wouldn't work for standard C compiler - definitions should come before the code.
There was a problem hiding this comment.
Then should the if(!pReq) code be removed? Because a null pointer dereference will occur before it reachs that.
There was a problem hiding this comment.
I would suggest splitting the definitions and the assignment if you need check before the assignment.
|
I'm going to close this, but if you could manually cherrypick the changes, that would be great. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various non-serious security issues, and some other stuff.