Zend/zend_type_code: remove hard-coded integer values #10714
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devnexen
reviewed
Feb 27, 2023
Also removing the comment about keeping those values in sync with `zend_variables.c` which was obsoleted by commit 0460420 (designated initializers).
MaxKellermann
force-pushed
the
type_code
branch
from
59a4590 to
ac09ddb
Compare
_Static_assert is C11, but has been supported since GCC 4.6.
MaxKellermann
force-pushed
the
type_code
branch
from
ac09ddb to
87d981b
Compare
devnexen
approved these changes
Feb 27, 2023
|
I object to this change, as it is now no longer possible to grep for this type values, which was always a huge help while debugging. |
|
it s reverted now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also removing the comment about keeping those values in sync with
zend_variables.cwhich was obsoleted by commit 0460420 (designated initializers)