Re-enable -Wstrict-aliasing #10821
Closed
Re-enable -Wstrict-aliasing #10821
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're not disabling -fstrict-aliasing to it's better to keep this warning.
value is a long. mysql_stmt_attr_get() writes to the most significant byte. Type punning was used to move that byte to the least significant one, which is UB. We can avoid this by simply casting to my_bool (alias of bool). Previously, a comparison against 0 should've been done.
|
Huh, I thought we did, this looks sensible to have if actually do use this optimisation. So LGTM |
Girgias
approved these changes
Mar 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're not disabling
-fstrict-aliasingso it's better to keep this warning.